Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The menubreadcrumb module removes the title on the Page Not Found page when active, any help?
Comment | File | Size | Author |
---|---|---|---|
#9 | no-title-patch.patch | 831 bytes | Bartezz |
Comments
Comment #1
AaronMcHaleComment #2
jweowu CreditAttribution: jweowu commentedAs the issue settings form points out:
Comment #3
AaronMcHaleCould I please get some help from someone?
Comment #4
jweowu CreditAttribution: jweowu commentedI just tested, and I don't see that issue for the default 404 page, or for a custom one.
My installation is using the latest patch from #595282: Menu weights (I'd be surprised if any of those changes affect this, but I mention it just in case).
Comment #5
AaronMcHaleWill that patch be included in the latest version?
Comment #6
jweowu CreditAttribution: jweowu commentedThat didn't make sense. Do you mean "Is that patch included in the latest release" or "Will that patch be included in the next release" ?
("No" to the former, and "I don't know" to the latter.)
Read the handbook page on applying patches if you'd like to try it out for yourself (although as I said before, I'd be a little surprised if this patch had any effect on your problem).
Comment #7
AaronMcHaleSorry, I meant the former, it could be another module causing this problem, I could try disabling some modules and see if it works.
Thanks
Azz McH
Comment #8
xurizaemonThanks for updating.
I'm marking this issue closed - if you do find it's related to this module (ie, the problem can be reliably reproduced when this module is enabled, and goes away immediately when it's disabled) then please re-open this ticket, and provide a list of the other modules you have enabled for reference.
Comment #9
Bartezz CreditAttribution: Bartezz commentedOld issue but re-opening. Using latest stable version of menu breadcrumb. When visiting a page that results in a 404 (either with search404 enabled or disabled) I used to get the single breadcrumb 'Home'. Now with menu breadcrumb enabled I get a single breadcrumb that points to the page itself but without a text
<a href="/bad/url/test" class="active"></a>
.This only happens with the option 'Append page title to breadcrumb' checked. If I uncheck this option there is no breadcrumb at all. I've disabled any modules that could be causing or related like search404, page title, etc.
Looking at the source of menu_breadcrumb.module starting at line #340 and doing some debugging I found that drupal_get_title() doesn't get a title on hook_init. I've tried chaging module weight but that didn't have effect ofcourse. So I've created a patch to prevent the creation of an 'empty' breadcrumb.
Changed the title to hopefully make things more clear...
Cheers
Comment #10
jweowu CreditAttribution: jweowu commentedChanging status. (You can't set your own patch to RTBC.)
Comment #11
gooddesignusa CreditAttribution: gooddesignusa commentedthere seems to be an issue with calling drupal_get_title on a 404 page.
I'm using the blocks404 module to show my primary menu on 404 pages. When I enable menu_breadcrumbs it removes the 'Page Not Found' title. If I comment out the lines that call drupal_get_title() the title wont get cleared.
I tried to check the headers with drupal_get_headers but for some reason all I was getting was 'Content-Type: text/html; charset=utf-8'
I was going to have it not call drupal_get_title if it detected a 404 in the headers.
Comment #12
xurizaemonCleaning up issue queue. Closing all D6 issues.
If you believe this issue still applies to a supported version, feel free to re-open it. That would be a great time to check if the issue contains clear steps for reproducing the bug!
Thanks and sorry for any inconvenience.