Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 47.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 48.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 49.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 50.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 51.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 52.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 53.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 54.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 55.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 50.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 51.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 52.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 53.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 54.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 55.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 56.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 57.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_block.inc on line 58.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 164.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 165.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 166.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 167.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 164.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 165.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 166.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 167.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 164.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 165.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 166.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 167.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 164.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 165.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 166.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 167.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 164.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 165.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 166.
warning: Attempt to modify property of non-object in E:\xampp\htdocs\amater\sites\all\modules\calendar\includes\calendar_plugin_display_attachment.inc on line 167.
That's what i've got with Calendar 2.2 and Date 2.4. Related thread here http://drupal.org/node/549884 . I've aplied patch no.10 and the warning was gone without the calendar module. I'm not going to apply the same fix in all of those files so i'm looking up and forward for a commiter :)
Thanks
Alex
Comment | File | Size | Author |
---|---|---|---|
#60 | calendar-6.x-2.x-1276487524.patch | 4.62 KB | hswong3i |
#48 | 613528--views-compatibility.patch | 4.52 KB | dingbats |
#22 | calendar-6.x-2.x-dev_0.patch | 4.29 KB | arlinsandbulte |
#5 | calendar-6.x-2.2-613528-5.patch | 4.04 KB | davidwatson |
Comments
Comment #1
Rosamunda CreditAttribution: Rosamunda commented+1!
Comment #2
ywpeng CreditAttribution: ywpeng commented+2
Comment #3
davidwatson CreditAttribution: davidwatson commentedI'm currently trying a more robust fix for the related issue in the date module - as others have pointed out, I'm almost certain this only has to do with PHP 5.3.0 suddenly realizing that treating the passed array as an object makes little sense, and it just went unnoticed until now. :] If it works as expected, I'd be happy to roll a patch for review, since I need this fix for my own installs one way or the other.
Comment #4
Alex Andrascu CreditAttribution: Alex Andrascu commentedI'd be happy to test that patch :)
Comment #5
davidwatson CreditAttribution: davidwatson commentedJust tested the following; everything seems to be in order on my installs, running PHP 5.3.0. Review and feedback welcome!
Comment #6
andrewfn CreditAttribution: andrewfn commentedJust applied it to 12 production sites and it has saved my skin. Thanks so much!
I also recommend setting the value of
date.timezone
in php.ini which gets rid of some of the php 5.3 error messages.Comment #7
drjagan CreditAttribution: drjagan commentedPlease somebody explain how to apply this patch??
SHould I upload to my server and run it from somewhere?
Please let me know.
THank you.
Jag
Comment #8
davidwatson CreditAttribution: davidwatson commentedGlad I could help, Andrew! :] Good call on the date.timezone issue; forgot to make a mention of that...
Jag, have a look at http://drupal.org/patch/apply for instructions on how to apply patches. If you do, let us know here how it works out for you!
Comment #9
WSRyu CreditAttribution: WSRyu commentedHey, thnx for the info, im also a new-user.
The patch will most likely not help me with this error would it?
An error occurred at /drupal-6_14/admin/build/views/ajax/display/date_browser/default/style_plugin.
I just ignore all the errors as mentioned above and continued building the calendar. When i go to
localhost/drupal-6_14/admin/build/views/edit/date_browser
and i want to change the Style, i get this error, actually with whatever i click...
An error occurred at /drupal-6_14/admin/build/views/ajax/config-item/date_browser/default/argument/date_argument.
Will the patch help? probably not as it only ignores the error right?
thnx for any help!
Comment #10
tnanek CreditAttribution: tnanek commentedThis patch works for me, though I haven't looked at the code itself.
Comment #11
davidwatson CreditAttribution: davidwatson commentedAll the patch does is treat the array as an array rather than an object, now enforced by PHP 5.3.0.
Someone else care to RTBC this?
Comment #12
andrewfn CreditAttribution: andrewfn commentedThe code looks good. (Have tested it as well). RTBC.
Comment #13
WSRyu CreditAttribution: WSRyu commentedNope, patch doesn´t work for me! this is the error i get upon clickin on save.
Parse error: parse error in C:\wamp\www\drupal-6_14\sites\all\modules\calendar\includes\calendar_plugin_display_page.inc on line 47
i edited the patch by hand and im pretty sure i did exactly as the patch mentioned.
any ideas?
Comment #14
davidwatson CreditAttribution: davidwatson commentedThe parse error above suggests that there's a missing semicolon or somesuch - that is, that the patch wasn't applied correctly. A quick Google will be able to tell you the common culprits. Please follow the steps at drupal.org/patch/apply, preferably using the command line (or similar). Applying patches manually is typically frowned upon, due to the human error that can result. If there is still a bug, I'd be happy to investigate.
Thanks!
Comment #15
dbarkman CreditAttribution: dbarkman commentedRan the patch and it worked great! Thanks
Comment #16
WSRyu CreditAttribution: WSRyu commentedHey c.ex,
thanks a lot, it does indeed work, sorry bout that! But i still get an error on my homepage:
An error occurred at /drupal-6_14/admin/build/views/ajax/display/date_browser/default/style_plugin.
Any ideas on that?
Comment #17
davidwatson CreditAttribution: davidwatson commentedWSRyu -
Glad I could help! This patch was only intended to fix the above notices. I'd go ahead and create a new support ticket in the appropriate issue queue. The guide at http://drupal.org/node/314185 contains a lot of useful information on how to do this - it's easy to say there's something wrong, but being able to communicate exactly what the issue is (and how to duplicate it) makes life much easier on us devs.
HTH!
Comment #18
jonvk CreditAttribution: jonvk commentedThanks, the patch worked for me.
Comment #19
rmmcclay CreditAttribution: rmmcclay commentedThe patch worked for me too. But since I'm a novice at patching it took me a while to
figure out needing to create a directory "new_includes" and put the files there before
running the patch.
Comment #20
KarenS CreditAttribution: KarenS commentedThere are numerous issues like this all around Drupal. If you make this change, it may not work in PHP 4 and we're still supporting PHP4 in this version. This module is not the only one that has this problem, there are many others, including some core modules. PHP 5.3 may just be incompatible with code that tries to support PHP 4. And which version of Views are you testing against, Views 2 or Views 3?
If someone can thoroughly test that this won't break things in PHP 4, I'll consider it, but I don't have time to do that and I can't commit the change without that.
Comment #21
davidwatson CreditAttribution: davidwatson commentedThanks for giving this a once-over, Karen!
I tested this against Views 2. I'll see if I can't run some more thorough tests on different environments (Views 2/3, PHP 4/5) to confirm that nothing breaks, and I'd be happy to re-roll if that's what it takes. It will likely take me a bit, though, and I'd much prefer another set of eyes on this, so if someone else wants to take a stab then by all means!
Comment #22
arlinsandbulte CreditAttribution: arlinsandbulte commentedI marked #587424: compatibility with php 5.3 as a duplicate of this issue.
That issue included a patch from drasgardian.
I am attaching that patch to this post in case anyone finds it useful here.
Comment #23
Alex Andrascu CreditAttribution: Alex Andrascu commentedI really wanna see the end of this one day. Commited and oficial that is :)
Comment #24
davidwatson CreditAttribution: davidwatson commentedPatch in #22 needs work. What about the case in which it is an array? Some defaults will be left unset, no?
Comment #25
AdrianB CreditAttribution: AdrianB commentedSubscribing.
Comment #26
Ahqar CreditAttribution: Ahqar commentedI applied the above mentioned patch (#5) by hand.
As I have PHP 5.3 so have no need for compatibility with PHP4, I removed the '&' from the code. Correct me if I'm wrong but if you need PHP4 compatibility at any point I think you need to avoid that.
Anyway here is the manual way of applying the patch. Don't forget to backup the affected files before changing anything so that you can reverse the changes if it goes wrong.
In the calender module includes sub-folder ( includes/calendar_plugin_display_attachment.inc)
Where this code appears:
Change it to:
Also
In the same sub-folder (includes/calendar_plugin_display_block.inc)
Where this code appears:
Change it to this:
Lastly
In the same sub-folder (includes/calendar_plugin_display_page.inc)
Where this code appears:
Replace it with this:
I hope this helps anyone who cannot, for any reason, apply the patches in the normal way.
Comment #27
bomarmonk CreditAttribution: bomarmonk commentedI applied the patches with the patch command (#5) and manually with the instructions in #26. I still get the following error: Attempt to modify property of non-object in /mysite.com/sites/all/modules/date/includes/date_plugin_display_attachment.inc on line 26. Grrr! Thanks for the patches but I seem to still have this problem.
Comment #28
Buzzard CreditAttribution: Buzzard commentedThanks for this patch.
After run the patch manually, it reduced the long list of errors in my Views screen.
There is still one error remaining, though. Do you have a patch or solution for this one too?:
Thanks,
Comment #29
Ahqar CreditAttribution: Ahqar commented@ Buzzard
See Here: http://drupal.org/node/549884#comment-2250444 (#30)
What that patch does is in the date module it changes this file.
includes/date_plugin_display_attachment.inc
From this:
To this:
That fixed it for me.
Comment #30
bomarmonk CreditAttribution: bomarmonk commentedYes, the additional correction in #29 fixed the error I was still having. Thanks, Ahqar!
Comment #31
oriol_e9gtagged
Comment #32
jeffshultz CreditAttribution: jeffshultz commentedTried to apply the patch, got these errors:
mail:/home/larry/public_html/modules/calendar # patch < calendar-6.x-2.2-613528-5.patch
patching file calendar_plugin_display_attachment.inc
Hunk #1 FAILED at 161.
1 out of 1 hunk FAILED -- saving rejects to file calendar_plugin_display_attachment.inc.rej
patching file calendar_plugin_display_block.inc
Hunk #1 FAILED at 47.
1 out of 1 hunk FAILED -- saving rejects to file calendar_plugin_display_block.inc.rej
patching file calendar_plugin_display_page.inc
Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file calendar_plugin_display_page.inc.rej
mail:/home/larry/public_html/modules/calendar #
Sigh...... never mind. Helps if I actually look at which files I'm supposed to be patching. First time I've ever done this.... welcome to the curve, eh?
Comment #33
asanchez75 CreditAttribution: asanchez75 commentedgreat! thanks!
Comment #34
hawleyal CreditAttribution: hawleyal commentedPatch in #5 works with 2.2.
Comment #35
benone CreditAttribution: benone commentedsubscribe
Can I ask maintainer to put info here where the proper patch will be implemented in dev. Thank you.
Comment #36
harking CreditAttribution: harking commentedPatch in #5 works with dev and 2.2
Issue is related to #698522: Make date compatible with both views 2 and views 3
Comment #37
thirdangel CreditAttribution: thirdangel commentedpatch in #5 worked for me. did it manually. Failed the first time, but the second time was the charm!
Great thanks c.ex
Comment #38
harking CreditAttribution: harking commentedComment #39
harking CreditAttribution: harking commentedComment #40
davidwatson CreditAttribution: davidwatson commentedAlthough I appreciate the support folks, see Karen's response in #20, and my follow-up in #21. This hasn't been adequately tested in PHP 4 yet for it to be considered for inclusion in -dev, and it completely lacks testing for Views 3 from what I can tell. Apologies for the <strong>, but it seems a lot of people are scanning the issue and missing why it hasn't been committed yet.
Marking as CNR until tested and confirmed in the following environments:
PHP 5.3, Views 3
PHP 5.2, Views 3
PHP 4, Views 2
PHP 4, Views 3
Already confirmed using the following:
PHP 5.3, Views 2
PHP 5.2, Views 2
Things are starting to slow down a bit, so hopefully I can devote some attention here again in the very near future. Karen, if you think this should still be CNW still feel free to set it back, but the fact that it needs more testing before going one way or the other makes me wonder if CNR is a better fit.
Comment #41
NoDice CreditAttribution: NoDice commentedNot sure if this is the same issue but here goes...:
After upgrading to latest dev versions for views 2, calendar 2 and date 2, I'm getting the following error whenever I look at a calendar view that has date nodes in the current view:
"Fatal error: Call to a member function advanced_render() on a non-object in ...\views\theme\theme.inc on line 225"
Calendar 6.x-2.x-dev (2010 April-1)
Date 6.x-2.x-dev (2010-Mar-26)
Views 6.x-2.x-dev (2010-Apr-07)
PHP Version: 5.2.9
MySQL: 5.1.33
Again, I only get this error if the calendar view has date nodes. For example, empty month view is fine, empty day view is fine, but any view that has even 1 date node produces this error.
Is my issue related?
UPDATE: This issue has been fixed. It was a bug in Views 2.9. Patch has been committed in latest release (Views 2.10). See this thread over at views: advanced_render() error when viewing calendar
Comment #42
arlinsandbulte CreditAttribution: arlinsandbulte commentedNoDice: I don't think your errror is related to this issue (at least closely, it might be a distant relative) because your PHP version is 5.2, not 5.3.
Note: I modified the title to clarify which module this issue applies to (date has another issue with the same title).
Comment #43
boabjohn CreditAttribution: boabjohn commented@NoDice: I have your same config and am getting this error, but only since lasst night's security upgrade to Views 6.x-2.9.
Applied patch from #5, but "nodice".
Do we need another issue thread?
Comment #44
boabjohn CreditAttribution: boabjohn commentedFollowing from KarenS at #20, found another reference (numerous issues?) but at least this one did not seem connected directly to the version of PHP, but to "the way custom fields are added to the "Search and reference" views" (via markus_petrux)
http://drupal.org/node/668554
I'm too chicken to try rolling Views back to 6.2.8 and see if Calendar springs to life again. Anyone else have trouble since update to 6.2.9?
Comment #45
NoDice CreditAttribution: NoDice commented@boabjohn and arlinsandbulte
UPDATE: My issue I mentioned earlier in this thread has been fixed (Views related).
My issue was related to Views 2.9. It was producing advanced_render() error when attempting to display calendar view with dates. I posted my issue over at Views and the critical bug has been fixed in latest Views 2.10. See this issue at Views for fix: advanced_render() error when viewing calendar
Comment #46
boabjohn CreditAttribution: boabjohn commentedThanks heaps for the pointer NoDice. All playing nicely on the same page now.
Comment #47
Andrew Schulman CreditAttribution: Andrew Schulman commentedsubscribing
Comment #48
dingbats CreditAttribution: dingbats commentedMoved stuff from options() to options_definition() like what was applied for a similar issue (i.e. #698522: Make date compatible with both views 2 and views 3) in the Date module.
I'm only quasi-sure this is the way to go. Somebody step up and review it.
Comment #49
radicsge CreditAttribution: radicsge commentedComment #50
radicsge CreditAttribution: radicsge commentedsorry my mistake, it works for me
Comment #51
pendashteh CreditAttribution: pendashteh commentedFound a solution!*
just copy this code in the template.php of your theme.
You can define every disturbing error message in the $aBypass array.
other friends can make it available as a patch to drupal core.
Comment #52
mikeybusiness CreditAttribution: mikeybusiness commentedsubscribing
Comment #53
powery CreditAttribution: powery commentedSubscribe
Comment #54
Sera CreditAttribution: Sera commentedPatch from #5 works very well for php5.3. Thank you.
#51: I guess that solution is simply to circumvent printing out the error messages due to modifiying the theme. Am I right?
Comment #55
Carlos Miranda Levy CreditAttribution: Carlos Miranda Levy commented.
Comment #56
Carlos Miranda Levy CreditAttribution: Carlos Miranda Levy commentedPatch #5 http://drupal.org/node/613528#comment-2250424 worked for me.
Thanks.
Comment #57
Anonymous (not verified) CreditAttribution: Anonymous commented.
Comment #58
rolfmeijer CreditAttribution: rolfmeijer commentedsubscribing
Comment #59
hermx CreditAttribution: hermx commentedThanks for the help,
#26 / #5 worked for me on calendar-6.x-2.x-dev.
Comment #60
hswong3i CreditAttribution: hswong3i commentedSubscribing. Patch revoke via #5 and CVS with DRUPAL-6--2.
Fully tested with Drupal 6.17 + Debian Squeeze + PHP 5.3.2-1 + calendar 6.x-2.x-dev.
Should we change this issue as RTBC?
Comment #61
frobsubscribing
Comment #62
alanvee CreditAttribution: alanvee commentedThis patch def fixes the problem ( $display->display_options should be $display['display_options'] but also needs to be applied to the DATE module. I'm new to patching, but the current patch appears to ONLY fix the CALENDAR module. I ran it via Tortise (not a bad app!) and after still got same complaints from Drupal about the DATE includes.
At understandable risk, I did the patch to DATE via Ultraedit search and replace and no more messages from Drupal on this subject.
THANKS for the patch!
=Alan R.
Comment #63
codekarate CreditAttribution: codekarate commentedI can confirm that #60 at least fixes the errors. Using PHP 5.3, Drupal (Pressflow) 6.16, Nginx, calendar 6.x-2.x-dev.
Comment #64
Screenack CreditAttribution: Screenack commentedFYI: confirming patch worked here, too, for 6.x-2.x-dev
Comment #65
maschiltz CreditAttribution: maschiltz commentedtried the patch with the following modules in place
calendar 6.x-2.2 AND 6.x-2.x-dev
date 6.x-2.4 AND 6.x-2.x-dev
views 6.x-2.11
and once I run the patch, the errors are gone, but the 'Views' page and the 'Modules' pages are both broken. All I get is an empty page for both of them. Anyone else get this or have any ideas?
Comment #66
maschiltz CreditAttribution: maschiltz commenteddisregard my previous post. I guess the patch did something strange with my permissions that I couldn't rectify. Instead I just went through and made the changes by hand, and it works fine now.
Comment #67
theposse CreditAttribution: theposse commentedPatch in #60 worked for me as well. We have the same configuration as #65. Thanks for putting this out.
Comment #68
dooug CreditAttribution: dooug commentedsubscribe
Comment #69
PenguinPie CreditAttribution: PenguinPie commentedThank you. Finally got it working, but has to implement the patch manually. Now I can get some sleep :)
Comment #70
RdeBoerLike so many others had this problem when migrating to a site that had PHP 5.3.1 installed (as opposed to 5.2.x).
Just to say that the patch in #60 worked for me when applied to Calendar 6.x-2.2.
Confirming that the Date module needs a similar treatment.
Thank you hswong3i and all involved.
Comment #71
hswong3i CreditAttribution: hswong3i commentedRefer to replies since #60, I would like to mark this issue as RTBC.
Comment #72
davidwatson CreditAttribution: davidwatson commentedSee my response back in #40, and Karen's before that. The reason this wasn't committed before was insufficient testing in the newest version of Views, and in PHP 4. From what I can tell, it hasn't received any additional testing on these fronts, and therefore is still CNR.
Comment #73
agerson CreditAttribution: agerson commented+1
subscribe
Comment #74
mariomc CreditAttribution: mariomc commented+1 subscribe
Comment #75
globexplorer CreditAttribution: globexplorer commentedPLEASE! This issue is not only important to know for that procject. As you can see below there will be several modules that won't work correctly anymore with PHP 5.3.
GMAP: GMAP
Date: DATE
Calendar: CALENDAR
Administration Menu: ADMINISTRATION MENU
The reason is a change inside PHP 5.3 object and reference handling!
Comment #76
bdimofte CreditAttribution: bdimofte commentedI've taken a look at module Views, it doesn't use $display as an array anywhere, so setting $display['display_options'] is futile.
I haven't debugged this, but my bet is that the code that triggers the warning is correct. I think it's another chunk of code that wrongfully uses $display as an array and passes it here.
I recommend using the patch in #22, not the ones that set the array
Comment #77
yan CreditAttribution: yan commentedPatches from #5 and #22 failed for me. Applying #5 manually seems to solve the problem with PHP 5.3.3, Calendar 6.x-2.2 and Views 6.x-2.11.
I'm sorry, but I can't do PHP 4 testing.
Comment #78
hanspln CreditAttribution: hanspln commented#26 worked for me.
Tried first with #60, but then the view didn't display anything.
Deleted and copied back both Date (6.x.2-dev) and Calendar (6.x.2-dev) after failure to revert from patch #60.
PHP 5.3.2
Comment #79
cord1 CreditAttribution: cord1 commentedI had the same problem with Drupal 6.17 and also now 6.19
Apache: : Apache/2.2.15 (Linux/SUSE)
PHP: PHP Version 5.3.2
Drupal: drupal-6.19.tar.gz
Modules:
date-6.x-2.4.tar.gz
calendar-6.x-2.2.tar.gz
Combining #29 (Calendar module) and #26 (date module) solved the problem for me.
Comment #80
manual labour CreditAttribution: manual labour commentedThank you,
thank you,
thank you.
To #5 - c.ex for finding the solution and creating the patch.
#26 - Ahqar for documenting it so i could apply it by hand when i couldn't actually make the patch work (user error)...
and to all you beautiful people who put in all this time and effort to fix the bugs.
Apache: Apache/2.2.14
PHP: PHP Version 5.3.1
Drupal: drupal-6.19
Module: date-6.x-2.4
status: up and running
Thank you
Comment #81
MamaGubs CreditAttribution: MamaGubs commented#5 worked beautifully
PHP 5.3.1
date 6.x-2.6
calendar 6.x-2.2
Thank you, thank you, thank you!
Comment #82
riverc CreditAttribution: riverc commentedI looked at it as well, the parent function options() which is inherited all the way from the views_plugin class, never defines anything for $display as far as I can tell. Obviously, as OO programming dictates, you may 'inherit' the functionality all the way from the base class even while overloading its functionality. this is what the parent::options($display) is all about. The trouble is there is no definition of the function save on the level of the views_plugin function, and it is a stub.
I ran a few experiments, and if you just do
On a new a variable there is no problem; but if this variable has been defined as say, an array
Produces an error. (Warning: Attempt to modify property of non-object in ... )
This indicates that somewhere in the execution the variable $display which is passed to the function is being defined as something other than an object; based on the fact that we do not get an error when we assume it is an array I'm going to say it is being defined as an array.
I hope that clears this up, code-wise. Someone who knows more than I about PHP may have deeper insights into this error, but my examination of the problem indicates that changing the reference from object properties to array keys is the proper solution.
Comment #83
aspilicious CreditAttribution: aspilicious commentedMy drupal 7 patch for this. Is alrdy using the array solution.
#885030: Bunch of warnings
Comment #84
frenkx CreditAttribution: frenkx commentedThere are several "solutions" around for this issue. As far as I understand it, there is only one, that is going into the right direction although many of them suppress the Problem.
#48 solves the problem by using the API of Views 2 and Views 3 (removing calls to deprecated
function options(&$display)
and replacing them by calls tooption_definition()
. #36 already pointed toward the right direction and linked a related issue.The fix from #5 partly solves the problem for Views2, but answering #40: Views3 will not validate with the solutions from #5, #60, #22 and #83. If you want a Views2-only solution, #22 would be a good starting point, but you would need to add code for the case, that $display is not an object (basically keep the current code). But since that solution would be deprecated as soon as it is coded, I will not provide a patch.
To sum it up, I strongly support the patch from #48 which provides a long term solution for the problem and has the chance of being successfully tested in all environments named in #40.
Comment #85
rares CreditAttribution: rares commented#48 fixes the problem on php 5.3 and views 6.11.
it was patched of calendar-6.x-2.x-dev (jul 11).
to all other patching rookies like me: you are supposed to put the patch file in the calendar directory and run:
patch -p1 < 613528--views-compatibility.patch
I agree with everyone here who says that we should commit this into -dev ASAP.
Comment #86
tgvcdr CreditAttribution: tgvcdr commentedThanks. I used the command to patch the calendar module in drupal_commons-6.x-1.0 package.
Comment #87
KarenS CreditAttribution: KarenS commentedIn looking more closely, I think a different fix is needed. I committed changes to the dev version.
Comment #88
obris CreditAttribution: obris commented@KarenS: Thank you for the committed changes: i quickly tested the module and everything works smoothly and i was not able to detect errors.
Comment #89
Don Allen CreditAttribution: Don Allen commentedI manually applied #26 to a published site to be sure I could revert, and it worked splendidly. Thank you all very much.
Comment #91
matakucoklat CreditAttribution: matakucoklat commentedthanks.the patch is work for me.
i'm using manual patch and everything goes well.
Comment #92
davidhhuan CreditAttribution: davidhhuan commentedSubscribing
Comment #93
arlinsandbulte CreditAttribution: arlinsandbulte commentedNote: This issue is fixed in the -dev version according to Karen in #87. You do not need to apply a patch.
Please, use the dev version to verify the official fix.
Comment #94
trotskyicepick CreditAttribution: trotskyicepick commentedI am running Drupal Commons v6.x-1.1 and have tried both the manual patch and updating to the dev version, and I still get all the errors quoted in #1.
Help!!
Thanks
Doh, I had left a backup of the original calendar module in place, deleting this has solved the problem.
Thanks again.
Comment #95
ShaneOnABike CreditAttribution: ShaneOnABike commentedPhewf thanks for fixing this I can confirm that all the messages are now gonzo!
Comment #96
connexion.eu CreditAttribution: connexion.eu commentedchange directory to the includes directory in the calendar module directory:
sites/all/modules/contrib/calendar/includes
and execute the the patch there:
patch < calendar-6.x-2.2-xxxxxxxxxxx.patch
Comment #97
bombasticamy CreditAttribution: bombasticamy commentedThanks for taking the time to put in this information -- it saved me!
Comment #98
JBstrikesagain CreditAttribution: JBstrikesagain commentedThanks, calendar-6.x-2.x-dev.tar.gz resolved this issue for me.
Comment #99
bendiy CreditAttribution: bendiy commentedSub... waiting for an official release.
Comment #100
Kutakizukari CreditAttribution: Kutakizukari commentedsubscribing
Comment #101
Gábor HojtsyFound this when seeing this error on drupal.hu, that we are updating to PHP 5.3. Looking forward to a stable release, thanks!
Comment #102
valderama CreditAttribution: valderama commentedsubscribing..
Comment #103
Nor4a CreditAttribution: Nor4a commented6.x-2.x-dev 2010-Nov-13
6.x-2.x-dev 2010-Oct-23
worked for me on:
PHP 5.3.0
MYSQL 5.1.37
Comment #104
dasjosubscribing
Comment #105
dasjodoesn't seem fixed to me, setting active again
Comment #106
arlinsandbulte CreditAttribution: arlinsandbulte commenteddasjo:
Have you tried the -dev release? Everyone else has confirmed that this is fixed in the -dev.
If you still have the problem with the -dev, please provide detailed instructions on how this can be reproduced.
Comment #107
dasjoarlinsandbulte: sorry my fault :)
Comment #108
mheinke CreditAttribution: mheinke commentedThank you for the patch in #5, saved my neck on my company's intranet
hope this helps. this is my full report, the patch broke absolutely nothing
WEB SERVER: Apache/2.2.3 (Red Hat)
Drupal Version: 6.19
PHP VERSION: 5.3.3
DATABASE TYPE: mysql; VERSION: 5.1.52
MODULES
Comment #109
sobrien.808 CreditAttribution: sobrien.808 commentedPatch from #5 worked for me, thanks! Is this going to be rolled into the calendar module so that next update will not break it again?
Comment #110
dasjosobrien.808 yes, as this has been committed to dev it should come with the next release
Comment #111
arlinsandbulte CreditAttribution: arlinsandbulte commented@ sorbrien.808:
YES!
See my post in #93: http://drupal.org/node/613528#comment-3483232
Comment #112
goliat CreditAttribution: goliat commentedPatch from #5 worked fine for my project, thanks a lot!
I'm waiting the next release of the module.
Comment #113
jamhitz CreditAttribution: jamhitz commentedWorked for me too. Thank you.
Comment #114
thedavidmeister CreditAttribution: thedavidmeister commentedissue has evaporated in the dev version. Thanks!
Comment #115
pjaszkow CreditAttribution: pjaszkow commentedThanks, man! The patch worked great!
Comment #116
Enemy CreditAttribution: Enemy commentedThanks! Works!
Comment #117
John Franklin CreditAttribution: John Franklin commentedAny chance of cutting a new release with these php 5.3 fixes soon? It's been a year and a half since the last release.
Comment #118
thePanz CreditAttribution: thePanz commented@Jhon: if you're in a hurry you can use the latest -dev package or pull down the CSV branch :)
by the way: I think that the new huge features added could aim a new "official" release! :)
Comment #119
John Franklin CreditAttribution: John Franklin commentedI avoid running -dev versions as I don't want to have to manage the bug-of-the-week on production sites. I'm more likely to backport select patches (like these 5.3 patches) to the release version to solve the specific issues I do have.
I think a year and a half is a bit long to go between Recommended Releases. I think we should have seen a 2.3 release by now or at least a 2.2.1 with patches from some "critical" bugs. I haven't been tracking the code base, but I could see this many months of effort adding enough to justify a 3.0 version bump.
Comment #120
jduhls CreditAttribution: jduhls commentedboth patches don't work for me - i get the "hunk failed" message (story of my life). subscribe!
Comment #121
KarenS CreditAttribution: KarenS commentedSee #945346: 6.x-2.3 Recommended release due date -- it has been a year and half since the last release because there haven't been any significant changes until the last few weeks.
Comment #122
John Franklin CreditAttribution: John Franklin commentedadd the more commonly used 'php5.3' tag.
Comment #123
nightowl77 CreditAttribution: nightowl77 commentedSubscribe
Comment #124
sobi3ch CreditAttribution: sobi3ch commentedUpdating calendar module to latest 2.4 solve the problem
Comment #126
_snake_ CreditAttribution: _snake_ commentedSubscribe
I am using:
Drupal 6.16
MySQL 5.1.49
PHP 5.3.3-7
Apache/2.2.16 (Debian)
Calendar 6.x-2.2
Date 6.x-2.x-dev
BeautyTips 6.x-2.0
Calendar Tooltips 6.x-1.7
Calendar iCal 6.x-2.2
Calendar Popup 6.x-2.2
Views 6.x-2.8
I solved that issue using #26 , but I want to update the module.
So, can anyone explain me the correct versions of the following modules?
Calendar
Date
BeautyTips
Calendar Tooltips
Calendar iCal
Calendar Popup
Views
Thanks!
Comment #127
_snake_ CreditAttribution: _snake_ commentedComment #128
arlinsandbulte CreditAttribution: arlinsandbulte commentedThe latest stable versions of Date & Calendar are PHP 5.3 compatible.
Date 6.x-2.7
Calendar 6.x-2.4
As for the rest of the modules, you can either test it yourself or ask in their respective issue queues.
Comment #129
Steve Bizuns CreditAttribution: Steve Bizuns commentedhallelujah to comment #29
Comment #130
marmora CreditAttribution: marmora commentedBig Thanks .. it Works great .. :))
Comment #131
apaderno