Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The code is trivial but so is the patch to support it so here we go. Ran some quick tests but didn't have CVS and needed this in a hurry so patched against our repository. Patch works for me, and can be applied.
Reviews welcome!
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | generalize_ctools_passthrough.patch | 1.79 KB | neclimdul |
Comments
Comment #1
neclimdulerr patch...
Comment #2
neclimdulCommitted and pushed to 6.x
Comment #3
neclimdulComment #4
neclimduldope, wrong window, sorry.
Comment #5
magnusk CreditAttribution: magnusk commentedWhen I try to update to the newest version of the module (with drush) I get the following error:
Call to undefined function _ctools_passthrough
Looks like the above patch changed the name of the function.
Comment #6
merlinofchaos CreditAttribution: merlinofchaos commented1) Please don't completely hijack issues. It's rude.
2) If you do, please understand what the statuses mean. It's not like there aren't plenty of explanations available. 'needs work' is totally not appropriate.
3) Yes, the name of the function changed. A quick grep shows that _ctools_passthrough is no longer called anywhere in CTools. If some other module is calling it, then they're at fault for calling a private function and they need to be updated.
Either way, this should've been a new issue, possibly linking back to this one. And you need to determine what module is calling _ctools_passthrough and file against that.
Comment #7
magnusk CreditAttribution: magnusk commentedI don't know what caused the error message when running "drush up" for ctools. All I know is that the undefined function name was changed by this patch. How is that "completely hijack"? Sorry if I I don't understand how to indicate an apparent patch problem with the Status.
I thought the error related to this patch. I didn't know why there was an update error but it seemed to be related to the patch. What should I have done?
Comment #8
neclimdul@magnusk couple things.
1) closed issues don't show up in issue queue lists so no one will see your comments
2) Related, yes. this issue did change that function name. But as merlin pointed out, that's using the drupal standard _ prefix implying internal to the module. So if there's something still calling it then that's an issue for the maintainer that made that mistake.
3) Without pretty much the full error no one will be able to tell you how to fix it or what caused the problem.
Please create the new issue as merlin suggested with the full error and we'll take it from there. We do appreciate you searching this issue queue first just wasn't the right issue this time.