I found that after upgraded from the old -dev to 3.0-alpha, my slideshow's does not show the pager correctly anymore.

Previously, the banner has the pager ("1 2 3 4...") with the active pager item highlighted by CSS class ".active". But after the upgrade the ".active" is no longer there. And at the Views' "Style Setting"-> "Style" -> "Slideshow -- > the gear button", no mater how I set at the "Pager" option, the setting gone after updated and saved the Views (all blank when I come back).

CommentFileSizeAuthor
#20 1090150-d7-2.patch13.9 KBredndahead
#18 1090150-d7-1.patch14.01 KBredndahead
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

metakel’s picture

Title: active pager not styled, Widget settings' blank » Pager settings cannot be saved, and active pager not styled

I have just tried again using the newest 7.x-3.x-dev (2011-March-12), the same things happens as in the alpha1's.

In previous version of 7.x-3.x-dev, the active pager has the below classes:

views-slideshow-pager-field-item views_slideshow_pager_field_item views_slideshow_active_pager_field_item views-row-odd active

But in the new 2011-March-12's "dev" and "alpha1", the active pager has only the below classes:

views-slideshow-pager-field-item views_slideshow_pager_field_item views_slideshow_active_pager_field_item views-row-odd

The "active" was missing.

The second issue about "Widgets" at the Views editing page:
And at the Views' "Style Setting"-> "Style" -> "Slideshow -- > the gear button", no mater how I set at the "Pager" option, the setting gone after updated and saved the Views (all blank when I come back).
I found that the settings were saved into the system. But the next time you go into the setting page again, the settings are gone and all ticked options were blank.

I have temporarily returned to the previous 7.x-3.x-dev of 2011-March-09 until the above is fixed. Thank you for maintaining this great module!

metakel’s picture

Title: Pager settings cannot be saved, and active pager not styled » active pager not styled, Widget settings' blank
bavarian’s picture

subscribe

redndahead’s picture

Title: Pager settings cannot be saved, and active pager not styled » active pager not styled, Widget settings' blank

As far as the settings I forgot to mention you need the dev version of ctools in the release notes. I'll add them in. I'll look at the other issue soon.

redndahead’s picture

For the settings issue it was a little bit more than that. The patch that shows up in this issue will fix it.

#1091478: Bad Implementation of ctools dependent

Jerome F’s picture

I have the same problem with the active issue. There is no patch in the mentionned issue for the moment, but it was late wasn't it ? So I imagine it's just a matter of time :-)

DavidHadaller’s picture

Same issues with the alpha version: active class not being applied to the active pager item.

Thanks for all your hard work! Awesome module.
Dave

redndahead’s picture

Yeah I noticed that too. It will be fixed just need to have time.

mjgruta’s picture

will be waiting for a fix. thanks!

wilgrace’s picture

subscribe

pjinadu’s picture

subscribe

janadam’s picture

subscribe

bryancasler’s picture

subscribe

faunt’s picture

Note that no pagers are available on any version if Views Row Style is set to display Nodes. Needs Fields to act as widgets for pagers. This insight resolved issue for me, so posting here.

bryancasler’s picture

faunt, I'm using fields http://awesomescreenshot.com/00b9uqs6f

My first slide is given the unique class "views_slideshow_active_pager_field_item" but that class does not change no matter what slide is being displayed. Also, just to reiterate what the OP said, there is also no "active" class being included.

metakel’s picture

just tested again with the new 7.x-3.0-dev of 2011-Mar-24, same problem. The active pager is not styled with class "active".

redndahead’s picture

You'll see a post on here when it's fixed. I'm still working on it.

redndahead’s picture

Version: 7.x-3.0-alpha1 » 7.x-3.x-dev
Status: Active » Needs review
FileSize
14.01 KB

Here is the patch. Fixes a few issues.

Active not showing on pagers.
Active not showing when hitting previous and next.
Controls not switching the text between pause and play.
Better code comments and code layout.

mjgruta’s picture

I tried your patch using git apply 1090150-d7-1.patch and I get

1090150-d7-1.patch:13: trailing whitespace.
1090150-d7-1.patch:29: trailing whitespace.
1090150-d7-1.patch:39: trailing whitespace.
1090150-d7-1.patch:55: trailing whitespace.
1090150-d7-1.patch:65: trailing whitespace.

warning: squelched 29 whitespace errors
warning: 34 lines and whitespace errors.

is this normal?

I checked a views with Views Slideshow Pager Widget enabled but the Pager widget is not checked.
then I tried to check it and save the slideshow settings but I get the error when I save the Views. The settings are saved even though the error shows below. I guess this is a problem with Views module.

Fatal error: Call to a member function unpack_translatables() on a non-object in F:\www\drupal7\sites\all\modules\views\plugins\views_plugin_localization.inc on line 138

also the indexing style of Pager Widget is still on the left side.

Active not showing on pagers. is working but I haven't checked the other fix.

redndahead’s picture

FileSize
13.9 KB

What do you mean by the indexing style of the pager?

Here is an updated patch that removes white spacing.

redndahead’s picture

Status: Needs review » Fixed

This has been committed. Please open a new issue if you are still having problems with the indexing style.

vqmalic’s picture

subscribe

mjgruta’s picture

Status: Fixed » Closed (fixed)

Note: Don't use the patch because it has been committed. download the latest Views slideshow dev and Views dev version. Everything is now working well.

bryancasler’s picture

Status: Closed (fixed) » Fixed

The commit works for me, thanks!

Jerome F’s picture

Status: Fixed » Closed (fixed)

Thank you it works ok.

anthonyR’s picture

Subscribe

bavarian’s picture

so ... just before trying to uppgrade again, just asking if it works fine now to uppgrade from the 7.x-3.x-dev version to the 7.x-3.0-alpha1 version?

redndahead’s picture

Use the dev version. It's probably in the best shape right now.

bavarian’s picture

thank you ...

rootwork’s picture

Status: Closed (fixed) » Reviewed & tested by the community

Can we get this included in a new alpha version soon? The available updates keeps bugging me to "update" from dev to alpha1 (I'm not sure why, since the dev I have is newer than that release, but whatever).

Since this was clearly a bug, and we're still in alpha-land rather than full releases, it would be nice to have a new release with this included.

redndahead’s picture

Status: Reviewed & tested by the community » Closed (fixed)
redndahead’s picture

As soon as I'm comfortable with doing another alpha I'll roll it out.

shortspoken’s picture

Had the same issue not getting the .active class. Installing the most recent dev versions of ctools, views and views slideshow solved the problem.
Thank you.

mikefyfer’s picture

Status: Closed (fixed) » Active

Thanks for this module, it's awesome, have been using it since 6, and now setting it up for the first time on 7.

I can't get active class to show up for pager, but furthermore with the latest dev, the pager doesn't show up at all, nor do controls, only the slide counter is showing up.

Have tried with:
Views 7.x-3.0-rc1 as well as the latest dev (July 12)
Ctools 7.x-1.0-beta1 as well as the latest dev (July 12)
Views_Slideshow 7.x-3.0-alpha1 as well as the latest dev (June 27)
and every possible mix of the above.

Basically what i'm getting is the dev version of views_slideshow, the pager doesn't show up at all, and with the alpha1 it shows up and works fine, but does not get active class, regardless of which ctools or views version I try.

Thoughts?

metakel’s picture

mikefyfer: have you set to use Widget at the View's "Format" -> "Settings"? I have no problem in using the latest dev version now.

mikefyfer’s picture

Status: Active » Closed (fixed)

@metakel, yeah format > slideshow settings > widgets > bottom widgets and used pager type: fields with content: title.

In any case, went ahead and tried fresh today with the dev version and seems to be working fine... No idea what was up yesterday, but all seems well today! putting status back to closed.

Poieo’s picture

I had the same issue as mikefyfer after the update. Had to clear the site's cache to get the pager back...in case anyone has the issue.

kalilo’s picture

I had the same issue with pager using Thumbnails..no active class. tried many fixes without success, , I've finally the chance to come up with a work-around:
Create a view.
Add Global: Custom text field and rewrite it to display Your image instead of the text.
In views slideshow setting Use this field as pager.
Now you can apply an active class to your image.

Kristen Pol’s picture

This bug is still around (I guess it resurfaced at some point). It's a duplicate. See http://drupal.org/node/1144512#comment-6962460

adulfan’s picture

Ok it's 2013 and I am using version = "7.x-3.0" I have my pager set up, it works on click action as should but it's not working when images cycling. The class active is not being added for the current slide.
Any ideas? should I right my own ks fix for this or what?