The views style plugin isn't ported totally.

* hook_views_api doesn't exist
* the style plugin can't configure the options
* the preprocess for the view is removed/not working at all

So basically this patch fixes the issue and let's you to use the style plugin again

CommentFileSizeAuthor
#1 1095188-views_style-fix.patch4.49 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
1095188-views_style-fix.patch4.49 KB

Here is the patch.

Hydra’s picture

Hydra CreditAttribution: Hydra commented
Status: Needs review » Active

Thx for this patch!

jdelaune’s picture

jdelaune CreditAttribution: jdelaune commented
Assigned: Unassigned » jdelaune
Status: Active » Fixed

Thanks, awesome work I hadn't started work on the Views support yet, hence it's non existence :)

As for the @todo hack. I need to work on a better way to add all the JS and make the theming more flexible. Hopefully I'll have something in the next couple of days and will make the changes need to the views part as well.

Committed to dev.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Hey this wasn't fair.

Tryed to teach hydra how to use patch and git, but the patch always failed... because you commited it already :)

Thanks for committing the patch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mrsimonelliott’s picture

mrsimonelliott CreditAttribution: mrsimonelliott commented
Status: Closed (fixed) » Active

I've re opened this because whilst the committed patch #1 works fine when all nodes have files uploaded, if the file field is not mandatory and you have nodes in your view with no file uploaded you get two errors:
Undefined variable: player_type in jplayer_sort_files() line 187 of www/sites/all/modules/contrib/jplayer/includes/jplayer.theme.inc
Undefined offset: 0 in views_handler_field_field->get_items() line 648 of www/sites/all/modules/contrib/views/modules/field/views_handler_field_field.inc

Plus a broken jplayer is displayed on all rows with no results for the field.

The "no results behaviour" settings in views admin has no affect. Set this to "hide if empty" and he still shows the broken jplayer on rows with no results.

Darrin Breen’s picture

Darrin Breen CreditAttribution: Darrin Breen commented

I too get the same error: Notice: Undefined offset: 0 in views_handler_field_field->set_items()... when trying to display jPlayer through views. I've updated to the latest dev version of views (June 28th) and jPlayer and get this error only when the field is empty?

simon_s’s picture

simon_s CreditAttribution: simon_s commented

The same problem here.

matthewdolman’s picture

matthewdolman CreditAttribution: matthewdolman commented

I am also having the no results issue. An empty player is showing even though I have views set to hide the field if there are no results.

matthewdolman’s picture

matthewdolman CreditAttribution: matthewdolman commented

Quick fix until the problem is properly addressed

.jp-{display:none}

  • jdelaune committed 3de8cf1 on 8.x-2.x 
    Issue [#1095188] by dereine: Added Views support