When I enable the advanced forum modul, I receive this Message a dozen times.

Notice: Undefined property: view::$row_index in views_handler_field->get_render_tokens() (line 1198 of /var/kunden/webs/bcweb/spiderkingz/d7/sites/all/modules/views/handlers/views_handler_field.inc).

I'm using the actual 7.x-2.0-alpha1 of advanced_forum and the 7.x-3.x-dev views version.

CommentFileSizeAuthor
#1 1124116-notice.patch824 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Priority: Critical » Normal
Status: Active » Needs review
FileSize
824 bytes

Errors/warnings are actual problems. Notices should be fixed, but it's often it's just a bit like a codestyle issue.
See http://api.drupal.org/api/drupal/includes--bootstrap.inc/function/watchdog and http://www.ietf.org/rfc/rfc3164.txt
So update priority.

In d6 displaying notices would kill you!

This code now works more like the default table preprocess function.
You could use this in 6.x-1.x as well, because this is a function which is in views since a certain version.

Hydra’s picture

Priority: Normal » Critical
Status: Needs review » Active

patch from #1 dereine works for me! Thx

fubhy’s picture

Status: Active » Reviewed & tested by the community

Changing status

Hydra’s picture

Priority: Critical » Normal
Hydra’s picture

Status: Reviewed & tested by the community » Closed (fixed)

-

Hydra’s picture

Status: Closed (fixed) » Reviewed & tested by the community
troky’s picture

Version: 7.x-2.0-alpha1 » 6.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Ok, ok. Committed to 7.x-dev.

Thanks for the patch dereine.

dawehner’s picture

@troky

Hydra is still learning drupal.org :(

fubhy’s picture

Hydra = dereine's padavan :P

jamescarvin’s picture

You guys amaze me and we stand (or sit) indebted. I posted elsewhere on this as follows:

Notice: Undefined property: view::$row_index in views_handler_field->get_render_tokens() (line 1187 of /home/username/public_html/domainname.com/members/sites/all/modules/views/handlers/views_handler_field.inc).

This error message repeats quite a few times. I find it when browsing to the main page of the forum as any user. I will not want anyone seeing error messages other than admin. Of course, I don't want the error messages either.

Troky then directed me to this thread. Thanks! However, I'm a total newb and don't know what to do to fix the error.
I'm in D7 and have installed Advanced Forum 7.2x alpha1, CMA, ctools 7.x-1.x-dev, ACL-7.x-1.0-beta2

Maybe I should have avoided a dev version of ctools? Your help is always appreciated!

dawehner’s picture

 Advanced Forum 7.2x alpha1

You should better use the dev version of advanced forum, because it's fixed there.

dawehner’s picture

Remove the most useless issue tag ever seen.

mcdruid’s picture

Status: Patch (to be ported) » Closed (fixed)

Thanks dereine.

I tested the patch with views 6.x-2.12 and the render_fields method works fine.

Committed to the Advanced Forum 6.x-2.x branch (I had trouble attributing you as the patch author in git, sorry).

NPC’s picture

Thanks, the patch in #1 helped me on 7.x-2.0-alpha1.

mcdruid’s picture

Status: Closed (fixed) » Fixed

oops - realised I should have been setting issues to "fixed" rather than "closed (fixed)"

troky’s picture

Well, it is fixed and ported and there is no reason not to close it :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.