Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Every single time I use Devel Generate to create taxonomy terms I set "Max word length of term/vocab names" to 2 or 3 because I think it means how many words long the names will be. Generate content, after all, words the same setting "Max character length of titles". I propose, therefore, that in order to maintain consistency and decrease confusion, the former be changed to "Max character length of term/vocab names".
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | devel-763928-10.patch | 1.82 KB | TravisCarden |
| #9 | devel-763928-9.patch | 1.81 KB | TravisCarden |
| #3 | devel-763928.patch | 991 bytes | TravisCarden |
| #1 | devel-763928.patch | 683 bytes | TravisCarden |
Comments
Comment #1
TravisCarden CreditAttribution: TravisCarden commentedHere's a patch.
Comment #2
TravisCarden CreditAttribution: TravisCarden commentedComment #3
TravisCarden CreditAttribution: TravisCarden commentedOops! I was asleep at the wheel on that one. I misspoke: generate content doesn't say "max character length". (I changed the wrong bit of code in my patch and confused myself.) So I guess I'll propose that we change both instances of "max word length" to "max character length". Here's a new patch.
Comment #4
TravisCarden CreditAttribution: TravisCarden commentedComment #5
salvis-1
"word length" is the length of a word (not the number of words as you keep misunderstanding) — "character length" would be the length of a character, which doesn't make sense.
You need to fix this in your head. If this isn't feasible then look at the bottom of your settings.php file where you can override strings that don't work for you.
Comment #6
moshe weitzman CreditAttribution: moshe weitzman commentedDoes anyone care about word length? This is a pretty obscure feature, IMO. Perhaps we should remove it or hide from UI.
Comment #7
rootworkI'm confused -- on the generate content screen, it has a field for "Max word length of titles" which definitely DOES refer to the number of words in each title (try putting in "2" in that field -- you'll get titles with two words, not titles using words with two characters).
In the generate terms screen, the field says "Max word length of term names" and on the generate vocabularies screen, the field says "Max word length of vocabulary names," but these refer to the number of characters in each word, as noted by the OP.
So in one case "word length" means number of words, and in the two other cases, "word length" means the length of the word.
I'm not taking a side in this fight, but the two should definitely not say the same thing if they mean different things.
Updating this to 7.0 as it is present in that branch, but this should be addressed for both 6 and 7, obviously.
Comment #8
salvisPlease post a D7 patch that changes the first item to "Max number of words in titles" and the others to "Max number of characters in term names" / "Max number of characters in vocabulary names".
Comment #9
TravisCarden CreditAttribution: TravisCarden commentedHere's a patch that corrects the four instances of "Max word length" in
devel_generate.module.Comment #10
TravisCarden CreditAttribution: TravisCarden commentedOops. I failed to respect the distinction made by @rootwork and @salvis. And while I was in there fixing my mistake, I realized that these several labels are the only ones that use the abbreviation "Max". All the others in the same file use "Maximum". So I changed these to the long form as well.
Comment #11
salvisPushed to D8/D7, thanks!