Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Libraries versions were not updated to match what the module currently replaces (1.51 for jQuery and 1.8.11 for jQuery UI).
Patch coming up.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1099056-code_cleanups-2.patch | 11.67 KB | amateescu |
| #1 | 1099056-update_version_string_and_minor_code_cleanups.patch | 9.85 KB | amateescu |
Comments
Comment #1
amateescu CreditAttribution: amateescu commentedContents of this patch:
- update versions for jQuery and jQuery UI
- update hook comments to D7 style
- move jquery.cookie.js to
misc(there's no reason for it to stay inui/external)- update jquery.cookie.js version string to latest revision from github, since it doesn't have a proper release name
Comment #2
mfer CreditAttribution: mfer commented@amateescu jQuery cookie is distributed with jQuery UI, along with some other scripts, in the external directory. Keeping the external directory up to date is easy. I don't know that we should move jquery.cookie.js out of there even if we have a misc directory. I'm open to convincing. But, it's about maintainability.
The other updates were committed, nice catch.
Comment #3
amateescu CreditAttribution: amateescu commented@mfer, you're right :)
I saw that jquery.cookie.js is included by core in the misc directory so I thought we should also place it there, but keeping in sync with what is distributed with jQuery UI is better.
Comment #4
amateescu CreditAttribution: amateescu commentedSome of the changes from #1 were not commited (the hook comments), so here's another patch which fixes those comments and changes all occurrences of
$javascriptwith$libraries, as defined in hook_library_alter().Also, we should update
$libraries['jquery.cookie']not$libraries['cookie']. This change is included as well.Comment #5
mfer CreditAttribution: mfer commentedThis has been fixed. The only hold up in releasing 7.x-2.x (and pushing the code up to d.o) is to test jQuery 1.5.2 on Google CDN. Still waiting for them to push it up.
Comment #6
amateescu CreditAttribution: amateescu commented@mfer, the patch from #4 is different that the one in #1, and i don't see any commit for this one.. maybe you forgot to push it?
Anyway, after http://drupalcode.org/project/jquery_update.git/commit/fcd7f39, this needs a reroll.
Comment #7
mfer CreditAttribution: mfer commented@amateescu I had not pushed up all my changes. I was waiting until the Google Libraries CDN had 1.5.2 on it to push up the changes. They are up now along with version 7.x-2.2.