sending absolute value to format_plural avoids this

CommentFileSizeAuthor
#2 format_plural_absolutes-1124448-2.patch974 byteselky
#1 format_plural_absolutes-1124448-1.patch1.6 KBelky
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elky’s picture

elky CreditAttribution: elky commented
Status: Active » Needs review
FileSize
format_plural_absolutes-1124448-1.patch1.6 KB
elky’s picture

elky CreditAttribution: elky commented
FileSize
format_plural_absolutes-1124448-2.patch974 bytes

Rerolled patch to get rid of the other changes not relevant to this issue

marvil07’s picture

marvil07 CreditAttribution: marvil07 commented
Status: Needs review » Fixed

Good catch!

The point is that if format_plural receives a -1 it takes the plural form, WTF?

Patch committed to 6.x-2.x, 6.x-3.x and 7.x-1.x.

Thanks

elky’s picture

elky CreditAttribution: elky commented

Glad to be of assistance!

I'm actually at some point going to poke core with a patch (or you can if you like, I don't mind!) The linguistic nuances of format_plural are somewhat contentiously debated though.

elky’s picture

elky CreditAttribution: elky commented

As I expected, it's not an easy fix to put through core. http://drupal.org/node/1131926

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.