Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
More information on the data structure of these parameters would be helpful.
Comment | File | Size | Author |
---|---|---|---|
#8 | menu-menutreedatadoc-1050606-8.patch | 1.92 KB | bxtaylor |
#2 | 1050606.patch | 2.04 KB | jhodgdon |
Comments
Comment #1
jhodgdonOK. Someone will need to research this and figure out what the data structure is.
There's another minor problem with this docblock: in the @return, menu_tree_page_data function name should have () after it so it turns into a link on api.drupal.org
Comment #2
jhodgdonHere's a patch. Definitely needs a review...
Comment #3
jhodgdon8.x now
Comment #4
jhodgdon#2: 1050606.patch queued for re-testing.
Comment #5
jhodgdon#2: 1050606.patch queued for re-testing.
Comment #7
jhodgdonLooks like this needs a reroll. Probably a good novice project? Then needs a review...
Comment #8
bxtaylor CreditAttribution: bxtaylor commentedRerolled.
Comment #9
bxtaylor CreditAttribution: bxtaylor commentedComment #10
jhodgdonThanks for the reroll! Someone other than me needs to review the text in the patch also for accuracy and clarity (since I wrote the original patch, I cannot review it). Would you like to comment on the patch text?
Comment #11
bxtaylor CreditAttribution: bxtaylor commentedAh yes! It gets kinda lonely in an issue all by yourself ; ) I'll review the text. Should I just mark as reviewed when done?
Comment #12
bxtaylor CreditAttribution: bxtaylor commentedWhat's the standard for paragraph spacing in comments? Sometimes there's an extra line, sometimes not.
Comment #13
bxtaylor CreditAttribution: bxtaylor commentedNevermind, I read somewhere else in the core issue queue that it is standard for an extra line to be in between the @param and the @return. Still reviewing the text in the patch.
Comment #14
jhodgdonThe standards for formatting of documentation blocks are at:
http://drupal.org/node/1354
Thanks for reviewing!
Comment #15
xjmThanks @bxtaylor.
Comment #16
bxtaylor CreditAttribution: bxtaylor commentedNo problem @xjm. After review, the patch text makes sense to me and looks accurate.
Comment #17
cleverington CreditAttribution: cleverington commentedDitto on the clarity! Nice, simple, and direct!
Comment #18
catchThis looks like a good improvement to me. Committed to 8.x and moving back to 7.x for webchick.
Comment #19
jhodgdon#8: menu-menutreedatadoc-1050606-8.patch queued for re-testing.
Comment #20
webchickCommitted and pushed to 7.x. Thanks!