Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In logintoboggan.module, the error text "Access denied. You may need to login below or register to access this page." has two spaces between the sentences. This is problematic, as 1) it can be confusing to users trying to use string overrides to change it since the double space is not displayed when the string is displayed in the browser, 2) it's bad form.
In the following patch, I propose removing the space to avoid confusion and make the gods of typography happy.
Thanks for your consideration.
Comment | File | Size | Author |
---|---|---|---|
#3 | logintoboggan-6.x-error-spacing-1135870.patch | 11.44 KB | froboy |
#3 | logintoboggan-7.x-error-spacing-1135870.patch | 10.42 KB | froboy |
#1 | logintoboggan-error-spacing-1135870.patch | 607 bytes | froboy |
Comments
Comment #1
froboyPatch attached.
Comment #2
hunmonk CreditAttribution: hunmonk commentedi read over a few articles on the subject, and i agree that we should switch to a single space after a period. however, i will not accept the patch in its current format. this should be a module-wide fix, so i'll need two patches (one for 6.x and one for 7.x) which correct all instances of this issue in all files.
Comment #3
froboyThanks. I think these should take care of them all...
Comment #4
hunmonk CreditAttribution: hunmonk commentedcommitted to 6.x-1.x-dev and 7.x-1.x-dev, thanks!