The "Jump to Navigation" link is too important a feature for screen reader users to have break just because we want to use the Primary Links block instead of Zen's normal primary links display. This patch makes it so that, if the normal primary links display seems to be disabled, we try gamely to see if the primary links block will display somewhere, and if so, have "Jump to Navigation" link to that instead. There might be a more elegant way to do it, though…

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Garrett Albright’s picture

Status: Active » Needs review
Garrett Albright’s picture

For the record, this patch is currently in production at http://oldtowncoffeeeureka.com/ .

JohnAlbin’s picture

Status: Needs review » Needs work

Garrett, this is a great idea, but the code necessary to implement it is quite heavy. Also, if the site admin, like me, uses menu_block instead of menu.module blocks, then the skip link breaks again.

The way I handle this is to override page.tpl and change the URL to match what is actually configured on the site.

Maybe instead we could have a theme setting to set the link?

Garrett Albright’s picture

Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Needs work » Needs review
FileSize
2.64 KB

Hmm, like this?

JohnAlbin’s picture

Status: Needs review » Fixed

Yes, very nearly! Excellent starting point.

I tweaked it a little bit and committed it. http://drupalcode.org/project/zen.git/commit/ffb5438

Garrett Albright’s picture

Nitpick: It looks like in that diff, you're switching between curly and straight quotes in the theme-settings.php bit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.