Hierarchical Select's Features integration is broken because common.inc isn't included before hierarchical_select_common_config_set gets called in hierarchical_select_features_rebuild. The attached patch fixes the problem, though I'm not sure if it's the best place for that code.

CommentFileSizeAuthor
#12 hierarchical_select-features_include_common-1134838-11.patch594 bytesjeffschuler
#5 fix-missing-includes-1134838-5.patch785 bytesdavad
#4 fix-missing-includes-1134838-4.patch557 byteskyle_mathews
#3 fix-missing-includes-1134838-3.patch601 bytesdavad
#1 fix-missing-includes-1134838-1.patch909 byteskyle_mathews
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kyle_mathews’s picture

kyle_mathews CreditAttribution: kyle_mathews commented
Version: 6.x-3.7 » 6.x-3.x-dev
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community
FileSize
fix-missing-includes-1134838-1.patch909 bytes

I had the same problem. The Features page won't even load without this patch which took me awhile to track down the cause. It doesn't look like a patch got attached so I've attached one I created.

cotto’s picture

cotto CreditAttribution: cotto commented

How clever of me. The patch kyle_mathews posted is essential the same as mine. Thanks.

davad’s picture

davad CreditAttribution: davad commented
FileSize
fix-missing-includes-1134838-3.patch601 bytes

Rerolled Kyle's patch against 6.x-3.7 to include in a drush make file.

kyle_mathews’s picture

kyle_mathews CreditAttribution: kyle_mathews commented
FileSize
fix-missing-includes-1134838-4.patch557 bytes

Trying another patch for our make file.

davad’s picture

davad CreditAttribution: davad commented
FileSize
fix-missing-includes-1134838-5.patch785 bytes

The patch stopped applying correctly when we switched to pressflow. It looks like git-apply applies patches against the base of the working directory. Attached is a rerolled patch against a pressflow installation.

mcjim’s picture

mcjim CreditAttribution: mcjim commented

Patch(es) work(s).

Makes sense to move the include to within the if statement, though? Save it being called if not needed.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Looks good.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
CreditAttribution: wizonesolutions commented

This fixed it for me as well. +1.

jdwfly’s picture

jdwfly CreditAttribution: jdwfly commented

Definitely needs to be committed. Just ran into this issue today. Unusable without this small change.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: missing include breaks features » Missing include breaks Features
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

http://drupalcode.org/project/hierarchical_select.git/commit/c7df52e

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Closed (fixed) » Needs review
FileSize
hierarchical_select-features_include_common-1134838-11.patch594 bytes

Same thing for D7, to fix:

Call to undefined function hierarchical_select_common_config_set()

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Closed (fixed)

#12: that was fixed in [#1847974 ].

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

#12: that was fixed in [#1847974 ].