Based on my initial fork from kiphaas7's work, I had found a number of issues concerning the date which had to do with the default_timezone and other function call changes.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay’s picture

Status: Active » Needs review

Yeah, the result of not having some of this is always having this on signup creation:

Warning: array_push() expects parameter 1 to be array, null given in date_formatter_format() (line 453 of /home/rfay/workspace/d7git/sites/all/modules/date/date.module).
BTMash’s picture

I'm a little bit lost - is the patch causing other errors to come up or fixing the issue you are having?

rfay’s picture

Your patch is essential. (I was working on a similar one).

I just put it in CNR.

Balbo’s picture

Project: Signup » Date

Shouldn't this patch be in the "date" project?

Balbo’s picture

Project: Date » Signup

Ok, sorry for confusion. :-/
I didn't see the /sites/all/modules/signup/includes/date.inc.

jwilson3’s picture

The first part of the patch on this issue is somehow related to #1190944: Notice: Undefined property: stdClass::$language in _signup_date_get_node_scheduler(), which solves an actual error ($node->language, not being defined) which may have been causing the array_push error in the first place, but I'm not totally sure.

The patch on this issue may also solve the same issue by changing the order of the two if statements. I'm not 100% sure of the intended impact of switching the preference from where to grab the date value from, but the fact is $node->language will never be set because the $nodes passed to this function are not real nodes, so if by any chance, it gets past the first if, then it will still fail.

I wasn't experiencing the time-zone issues reported on this thread, so I ask that you also take a look at my issue as well, to perhaps combine forces.

Hardik C’s picture

FileSize
2.01 KB

Hi.

We can integrate this applied patch for the desired result.It will be needful

BTMash’s picture

Assigned: BTMash » Unassigned

Unassigned so others can do something about this.

jacob.embree’s picture

Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

#0 does not apply. Needs reroll.
#7 is a duplicate of #0.

jacob.embree’s picture

ashishdalvi’s picture

We will work on it in Drupal Mumbai Code sprint

ashishdalvi’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
1.02 KB

I have rerolled the patch.