Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Based on my initial fork from kiphaas7's work, I had found a number of issues concerning the date which had to do with the default_timezone and other function call changes.
Comment | File | Size | Author |
---|---|---|---|
#12 | 1112590-12.patch | 1.02 KB | ashishdalvi |
date_fixes-btmash-1.patch | 2.01 KB | BTMash |
Comments
Comment #1
rfayYeah, the result of not having some of this is always having this on signup creation:
Comment #2
BTMash CreditAttribution: BTMash commentedI'm a little bit lost - is the patch causing other errors to come up or fixing the issue you are having?
Comment #3
rfayYour patch is essential. (I was working on a similar one).
I just put it in CNR.
Comment #4
Balbo CreditAttribution: Balbo commentedShouldn't this patch be in the "date" project?
Comment #5
Balbo CreditAttribution: Balbo commentedOk, sorry for confusion. :-/
I didn't see the
/sites/all/modules/signup/includes/date.inc
.Comment #6
jwilson3The first part of the patch on this issue is somehow related to #1190944: Notice: Undefined property: stdClass::$language in _signup_date_get_node_scheduler(), which solves an actual error ($node->language, not being defined) which may have been causing the array_push error in the first place, but I'm not totally sure.
The patch on this issue may also solve the same issue by changing the order of the two if statements. I'm not 100% sure of the intended impact of switching the preference from where to grab the date value from, but the fact is $node->language will never be set because the $nodes passed to this function are not real nodes, so if by any chance, it gets past the first if, then it will still fail.
I wasn't experiencing the time-zone issues reported on this thread, so I ask that you also take a look at my issue as well, to perhaps combine forces.
Comment #7
Hardik C CreditAttribution: Hardik C commentedHi.
We can integrate this applied patch for the desired result.It will be needful
Comment #8
BTMash CreditAttribution: BTMash commentedUnassigned so others can do something about this.
Comment #9
jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented#0 does not apply. Needs reroll.
#7 is a duplicate of #0.
Comment #10
jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commentedComment #11
ashishdalviWe will work on it in Drupal Mumbai Code sprint
Comment #12
ashishdalviI have rerolled the patch.