Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
API page: http://api.drupal.org/api/drupal/modules--search--search.module/function....
The documentation for search_box()
makes a reference to theme_search_box_form()
in the "see also" section, but the function is not found in Drupal 6.
Comment | File | Size | Author |
---|---|---|---|
#11 | search_box-1098556-11.patch | 481 bytes | drupal_was_my_past |
#2 | theme_search_box_form-1098556.patch | 446 bytes | barbi |
Comments
Comment #1
jhodgdonYeah, that @see should be removed. I can't see anything to replace it with either. Good project for a novice doc contributor.
Comment #2
barbi CreditAttribution: barbi commentedComment #3
mr.baileysI think it's supposed to link to theme_search_block_form instead of theme_search_box_form.
If we change the function name in @see (rather than removing the reference) then we should also add a reference for theme_search_theme_form.
Comment #4
jhodgdonWhy is theme_search_block_form() relevant to this function? I don't think it's called from this function or very related? Besides which, theme_search_block_form() is not a real function. It's a dummy that shouldn't even exist on the API site, since it's just saying "this is really search-block-form.tpl.php.
Same with theme_search_theme_form() -- why relevant and isn't really a function.
Comment #5
mr.baileysIt's relevant for someone looking to theme the search box form. I'm ok with removing the references though, I was just curious where the current reference to
theme_search_box_form
came from.Comment #6
jhodgdonStatus was never changed.
This should just link to search-block-form.tpl.php as it does in Drupal 7/8. Good project for a novice patch contributor. Oh, it's already tagged. :)
Comment #7
jhodgdonun-assigning since barbi hasn't worked on this in quite a long time.
Comment #8
Everett Zufelt CreditAttribution: Everett Zufelt commentedSee #1285364: Remove search-block-form template for form rendering consistency
Comment #9
jhodgdonThis is a 6.x-only issue, so I don't think the proposed removal of search-block-form.tpl.php in 8.x affects us here. But hopefully that issue's patch will also remove the link in the doc header for 8.x...
Comment #10
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedWorking on this at BADCamp.
Comment #11
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedRemoved reference to theme_search_box_form() and added reference to search-block-form.tpl.php.
Comment #12
jhodgdonLooks good, thanks!
Comment #13
Gábor HojtsyThanks, committed, pushed.