Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Damien Tournoud’s picture

Status: Active » Needs review
FileSize
874 bytes

Status: Needs review » Needs work

The last submitted patch, 897650-sqlite-find-table-schema.patch, failed testing.

Garrett Albright’s picture

Title: DatabaseSchema_sqlite::findTables() doesn't support schemas » DatabaseSchema_sqlite::findTables() shouldn't find indexes
Status: Needs work » Needs review
FileSize
1.02 KB

It appears that the meat of this issue, that of supporting a schema prefix, has been fixed elsewhere. However, another part of the patch, that of limiting the query to only finding tables, still needs to be put into place, because otherwise, it may return indexes:

sqlite> SELECT name, type FROM sqlite_master limit 10;
variable|table
sqlite_autoindex_variable_1|index
actions|table
sqlite_autoindex_actions_1|index
batch|table
batch_token|index
blocked_ips|table
sqlite_sequence|table
blocked_ips_blocked_ip|index
cache|table

Reroll which addresses this, as well as clarifies a comment.

Garrett Albright’s picture

D'oh. Another reroll to address confusion in my updated comment.

Damien Tournoud’s picture

Version: 7.x-dev » 8.x-dev
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7

Yep. Sorry about the breakage.

Please commit to D7 and D8.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x.

Status: Fixed » Closed (fixed)
Issue tags: -Needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.