Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
After #851168: db_find_tables() expects tables to be prefixed, inconsistent implementation and documentation, DatabaseSchema_sqlite::findTables() needs to be modified to support schemas (ie. the schema.table
form for a table expression).
This is a requirement for #850852: Fix transaction failure and allow concurrent testing on SQLite.
Comment | File | Size | Author |
---|---|---|---|
#4 | 897650-limit-findtables-query-typo.patch | 1.02 KB | Garrett Albright |
#3 | 897650-limit-findtables-query.patch | 1.02 KB | Garrett Albright |
#1 | 897650-sqlite-find-table-schema.patch | 874 bytes | Damien Tournoud |
Comments
Comment #1
Damien Tournoud CreditAttribution: Damien Tournoud commentedComment #3
Garrett Albright CreditAttribution: Garrett Albright commentedIt appears that the meat of this issue, that of supporting a schema prefix, has been fixed elsewhere. However, another part of the patch, that of limiting the query to only finding tables, still needs to be put into place, because otherwise, it may return indexes:
Reroll which addresses this, as well as clarifies a comment.
Comment #4
Garrett Albright CreditAttribution: Garrett Albright commentedD'oh. Another reroll to address confusion in my updated comment.
Comment #5
Damien Tournoud CreditAttribution: Damien Tournoud commentedYep. Sorry about the breakage.
Please commit to D7 and D8.
Comment #6
Dries CreditAttribution: Dries commentedCommitted to 7.x and 8.x.