Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Line 22 of README.txt for version 7.x-2.0 is as follows:
Install as usual, see http://drupal.org/node/70151 for further information.
But this should read:
Install as usual, see http://drupal.org/documentation/install/modules-themes/modules-7 for further information.
If someone can direct me to documentation on how to create a patch with git I'll happily create a patch and post it to this thread - note that I'm working with a standard download of wysiwyg.module rather than a clone of the git repo from drupal.org.
Comment | File | Size | Author |
---|---|---|---|
#2 | Error-in-README.txt-1173476.patch | 563 bytes | jim0203 |
Comments
Comment #1
TwoDIf you have access to a Unix/Linux system or Cygwin, it'll be easier to create correct patches against the very latest code (the master branch in git).
http://drupal.org/node/707484 shows you how to do that.
Otherwise, you'll need the latest 7.x-2.x-dev snapshot to base the patch on, and of course a diff tool.
Create a copy of the "wysiwyg" folder and name it "wysiwyg_original" so you'll have an unmodified version to diff against. Modify the file in the "wysiwyg" folder and then run the diff tool recursively from their parent folder.
You'll need to make sure the diff tool creates patches with context, as in including a number of lines before/after the actual changes so the patch application tools can compensate for changes made since the patch was created.
The command I'd run would be:
diff -upr wysiwg_original wysiwyg
-u creates a "unified" diff with 3 context lines by default
-p isn't really needed in this case, but it would include the function in which the change was made
-r simply means it should include subfolders
Since you're not using git and creating a diff between two distinct files in two different folders, rather than creating a diff between a single file and a previous version of itself, you'll get the "wysiwyg" and "wysiwyg_original" foldernames as prefixes in the diff/patch file. This is ok since I can just tell the apply tool to ignore # path prefixes, but if we were using the testbot here, it'd complain about not being able to find the files. Patches are normally created from within the module folder, not its parent.
Comment #2
jim0203 CreditAttribution: jim0203 commentedThanks, TwoD. I followed the instructions as per http://drupal.org/node/707484 - patch attached.
Comment #3
jim0203 CreditAttribution: jim0203 commentedI had a few problems understanding the documentation you linked to, by the way - I've outlined my problem at http://drupal.org/node/1176474; if you get a chance to look it over I'd appreciate it :)
Comment #4
TwoDSure, I'll do that when I get back home after the weekend.
Comment #5
jim0203 CreditAttribution: jim0203 commentedI've had a look through the existing documentation and put together a tutorial that seems to make more sense, at least to me: http://state68.com/content/contributing-simple-patches-drupalorg-using-git
Comment #6
sunThanks for reporting, reviewing, and testing! Committed to master.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.