contextual links broken for blocks rendered by context [#1137794]

* Tested on Beta1 and Dev release with two different themes.
* Place any menu links block provided by Menu module in any region via a Context reaction.
* The contextual links for "configure block" appear in the hover links, but not "add item" or "configure links" links provided by Menu module.
* The same menu block placed in the same region via the blocks administration screen displays contextual links correctly.

Comment	File	Size	Author
#2	context-block-contextual-links-1137794-2.patch	811 bytes	fearlsgroove
#2
#1	context-block-contextual-links-1137794-1.patch	640 bytes	fearlsgroove
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

fearlsgroove CreditAttribution: fearlsgroove commented 21 May 2011 at 21:07

Title:	Block placement with Context module breaks contextual links provided by Menu module	» contextual links broken for blocks rendered by context
Status:	Active	» Needs review

File	Size
context-block-contextual-links-1137794-1.patch	640 bytes

This problem affects any contextual link other than the configuration block link. this is caused by the editable_block() function in context_reaction_block.inc, which wraps the block "content" element in order to insert the link tag that makes it editable at the end of the content element. Further down the block rendering pipeline, contextual links is in the wrong spot, so, except for the configure block link which is added very late in the pipeline, the other links aren't rendered (views, menus, etc).

Attached is a quick fix that leaves everything still functioning by grafting the "#contextual_links" into the render array in the spot it's expected to live, but as I suspect changing this render array like this will cause additional headaches down the road, a more robust solution may be in order. Such a solution would probably require changing the javascript code for admin.