Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If you have a header and bottom pager, they have the same id. This cause 2 problems.
#1 - div with same ids is bad
#2 - the jquery function to add and remove the active class only adds and removes from the header pager (because it comes first)
You may say, well it was only attended for 1 pager to be used. In my scenario I am using 2 pagers. One is the content title, the other one is non-numeric pager, kinda like the one on lullabot.com.
Comment | File | Size | Author |
---|---|---|---|
#4 | 1128930-d7-2.patch | 5.83 KB | tom friedhof |
#2 | 1128930-d7-1.patch | 2.04 KB | redndahead |
#2 | 1128930-d7-2.patch | 5.84 KB | redndahead |
Comments
Comment #1
redndahead CreditAttribution: redndahead commentedI would say it is intended to have 2 pagers. So this is bad moving to dev so i will see it.
Comment #2
redndahead CreditAttribution: redndahead commentedThis patch was committed with a follow up patch tracer.
Comment #3
tom friedhof CreditAttribution: tom friedhof commentedBoth patches from comment #2 did not make it into the last commit http://drupalcode.org/project/views_slideshow.git/commit/a7aa09b
The pager active class is broke using the latest dev version. I had to manually apply 1128930-d7-2.patch.
Comment #4
tom friedhof CreditAttribution: tom friedhof commentedI re-rolled the patch from comment #2 (1128930-d7-2.patch) again so that it works with drush_make.
Comment #5
redndahead CreditAttribution: redndahead commentedWhoops I had forgotten to push the commit. Can you make a patch for whatever you changed to get drush make to work?
Comment #6
BernieCram CreditAttribution: BernieCram commentedHi Redndahead,
I have just applied the patch in comment 4 and have found that it fixed the active class issues I commented about in this issue http://drupal.org/node/1144512#comment-4506724
Thanks so much to you for your work on this module and thanks tom for the patch!
Cheers
Bernie
Comment #7
tom friedhof CreditAttribution: tom friedhof commented@redndahead: I didn't make any changes, I just re-rolled the patch using --no-prefix so that the patch was in the correct format that drush_make expects.
@BernieCram: You shouldn't need to apply this patch if you grab the latest dev release dated June 14, 2011. @redndahead pushed this patch a couple days ago.
Comment #8
BernieCram CreditAttribution: BernieCram commentedThanks Tom, I should have checked for new dev, updated and all working as expected.
Cheers
Bernie