Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
API page: http://api.drupal.org/api/drupal/includes--form.inc/group/form_api/6
Describe the problem you have found:
The "reference" link is a generic link which resolves to the form reference for drupal 7. Since this is a drupal 6 api page, it would be more appropriate for the link to stay with the same version of drupal. ie: http://api.drupal.org/api/drupal/developer--topics--forms_api_reference....
Best,
Matt
Comment | File | Size | Author |
---|---|---|---|
#11 | form_api_doc_link-1154722-11.patch | 700 bytes | barbi |
#7 | form_api_doc_link-1154722-7.patch | 704 bytes | barbi |
#2 | form_api_doc_link-1154722-2.patch | 622 bytes | barbi |
Comments
Comment #1
jhodgdonGood catch! This would be a good project for a novice doc contributor to fix.
Comment #2
barbi CreditAttribution: barbi commentedComment #3
jhodgdonAh. One other thing -- in the next line, the link
http://api.drupal.org/api/file/developer/topics/forms_api.html
is now redirected to
http://drupal.org/node/751826
But perhaps we should just provide a link to
http://drupal.org/node/20427
instead, and make the link text be
Form API guide on Drupal.org
thoughts?
Comment #4
jhodgdonI had forgotten to change the status, sorry!
Comment #5
barbi CreditAttribution: barbi commentedI am guessing the URL http://drupal.org/node/20427 is wrong. Or am I missing some thing here?
I have replaced the link http://api.drupal.org/api/file/developer/topics/forms_api.html to http://drupal.org/node/751826
Suggested hyperlink text : Form API guide
Let me know if it is good and I ll submit the patch.
Comment #6
jhodgdonSorry, the link should have been http://drupal.org/node/204270 (last digit got cut off). That is the Form API section.
Comment #7
barbi CreditAttribution: barbi commentedUsing anchor text : Form API guide
Comment #8
jhodgdonLooks good! The only thing I'm not sure of is whether the API module works correctly with
@link ... @endlink
not all on the same line.
I also think maybe it's easier for a person reading form.inc to read if the links are all on one line. What do you think? I see that we don't have it in http://drupal.org/node/1354 as a standard to make them all on one line (probably because I'm not sure whether API module requires it or not).
Comment #9
barbi CreditAttribution: barbi commentedI am not sure either. Can the @endlink being on the next line?
If it will break the link or an HTML tag, I ll redo it.
Comment #10
jhodgdonI would need to test it in the API module to be sure... But there is no harm it making sure the links are on the same line (except that it would make the line wrapping less optimal), so let's do it.
Comment #11
barbi CreditAttribution: barbi commentedPut @endlink on the same line.
Comment #12
jhodgdonI think that's better, thanks!
Comment #13
Gábor HojtsyCommitted to Drupal 6, thank you.