Hi -
I am working on moving my site from Drupal 6 to 7. One of my own modules provided a Panels style plugin, and I had set style options for the entire Panels page. I did this by clicking a link on the "Content" page of the Panels UI that says "Display Settings," right above "Title type." I thought this was very useful - it makes sense to me to set style settings for the whole page rather than individual regions or panes.
In the new version, this link appears to be gone and I can't find it anywhere else. Is there still a way to set style options for the entire Panels page, and not just an individual region/pane?
Thanks,
Nathan
Comment | File | Size | Author |
---|---|---|---|
#18 | 1206806-wrapper-styles-18.patch | 47.87 KB | lucascaro |
#16 | 1206806-wrapper-styles-15.patch | 50.26 KB | stephanie.raad |
#14 | 1206806-wrapper-styles-14.patch | 33.76 KB | helior |
#13 | 1206806-wrapper-styles-13.patch | 50.25 KB | helior |
#10 | wrapper-styles-1206806-10.patch | 50.16 KB | helior |
Comments
Comment #1
VM CreditAttribution: VM commentedThis should be confirmed missing in 7.x-3.x-dev. Thus marking as such.
I don't specifically see the feature you speak of in the D7 version of Panels 3.x-dev but have confirmed it was in D6. Not sure if this is a regression that occurred during the port or if there is a reason the feature was dropped for when porting Panels from D6 to D7.
Comment #2
Letharion CreditAttribution: Letharion commented@merlin Has this feature been dropped?
Comment #3
helior CreditAttribution: helior commentedHere is a patch that introduces "Wrapper Styles" under the "Display settings" drop-down menu. This allows style plugins to provide "render display" callbacks that can be applied to the entire Panels page. The existing
"No style" and "Rounded corners" style plugins provide an implementation to style the Panels page.
Upcoming patch will include a style base type of "display" for use with Stylizer and possibly some more documentation..
Comment #4
helior CreditAttribution: helior commented** Update: just using the name "wrapper" not "display" for most references to the wrapper styles.**
This updated patch provides "wrapper" style base plugins, updated docs, and renamed array keys.
Comment #5
helior CreditAttribution: helior commentedEven more better! I didn't realize that wrapper settings weren't getting saved correctly. It's all good now. I changed the array key of where wrapper configurations are stored on the $display object to avoid name collisions.
Comment #6
Letharion CreditAttribution: Letharion commentedI've tested the feature, and I must say it looks really nice. The idea is useful and it works as advertised.
My only objection is that you could set the wrapper around the page content with Panels Everywhere instead. Helior commented that on IRC with
There's a bit to much code that I'm unfamiliar for me to feel comfortable saying I've reviewed it, so I'm assigning it to merlin for a second review.
Comment #7
helior CreditAttribution: helior commentedI encountered PHP notices while switching layouts. So I'm initializing the wrapper settings in panels_new_display(). One thing that concerns me is whether storing these configurations in the panel_settings display property is the right place or not.
Comment #8
helior CreditAttribution: helior commentedPosting some screenshots so people have an idea of what this patch accomplishes.
Wrapper Style settings for the display:
Style plugins can have separate render/settings/etc. callbacks for the "wrapper":
Here the "Rounded Corners" plugin wrapped around the entire display, as well as the regions within it:
Comment #9
SocialNicheGuru CreditAttribution: SocialNicheGuru commenteddoes not apply cleanly to panels
Comment #10
helior CreditAttribution: helior commentedHmm. The patch applied for me, but I did also notice a whitespace warning. At any rate, here's an updated patch that I /think/ will apply okay.
Comment #11
big_smile CreditAttribution: big_smile commentedI've tried this patch on two websites (applying it to the stable (non-dev) version of Panels and it works brilliantly.
The patch applies cleanly with no errors.
Is this patch likely to become a part of panels in the future (I'm just checking so I know if to use in on future projects)?
Is this feature all ready possible in Panels Everywhere? I looked around for the option, but could not find it.
Comment #12
Blue CreditAttribution: Blue commentedCan this module be integrated in the future?
http://drupal.org/project/panels_extra_styles
Saved me big time with HTML 5 wrappers for content. I really think this should be in core.
Comment #13
helior CreditAttribution: helior commentedMinor update that prevents a PHP notice about undefined index for wrapper_settings.
Comment #14
helior CreditAttribution: helior commentedRe-rolling.
Comment #15
kristougher CreditAttribution: kristougher commentedTested the patch in #14. It seems to work and the functionality is quite nice.
Some of the functions lack function comment, but that goes for a lot of the panels module.
There are some commented lines of code:
plugins/style_bases/wrapper/wrapper_rounded_shadow/wrapper_rounded_shadow.inc
+// 'preview' => 'panels_stylizer_display_preview',
plugins/styles/stylizer.inc w/plugins/styles/stylizer.inc
plugins/style_bases/wrapper/wrapper_plain_box/wrapper_plain_box.inc
+// 'preview' => 'panels_stylizer_display_preview',
I cannot say if these are relevant for future use.
Comment #16
stephanie.raad CreditAttribution: stephanie.raad commentedPatch #15, has a bug fix that exists in patch #13 and #14.
the bug fix allows for the patch 15 to be cleanly applied to panels 7.x-3.7
Comment #17
lucascaro CreditAttribution: lucascaro commentedRe-rolled for 7.x-3.9
Comment #18
lucascaro CreditAttribution: lucascaro commentedRe-rolling with --binary so images merge well...
Comment #19
lucascaro CreditAttribution: lucascaro commentedComment #20
joelpittetThis looks like a feature request