{comment}.timestamp not exists anymore and changed to {comment}.changed

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet’s picture

Version: 7.x-dev » 8.x-dev
FileSize
644 bytes

new patch for D8 and same patch of D7 above.

Caligan’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
1.14 KB

D8 patch looks fine. Revised the D7 patch comment_update number.

Status: Needs review » Needs work

The last submitted patch, comment-D7-1069080-2.patch, failed testing.

Caligan’s picture

FileSize
1.14 KB

One the bot should ignore....

Caligan’s picture

FileSize
643 bytes

Exact replica of #1 patch, un-suffixed to kick the testbot.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, D8comment.patch, failed testing.

Caligan’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
643 bytes

Exact was the wrong answer... updated diff to tip of latest.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, D8comment.patch, failed testing.

Caligan’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
644 bytes
Caligan’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
1.72 KB

Whitespace correction to D7 patch. Also defines defgroup updates-7.x-extra.

catch’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed this with Caligan in irc.

The 8.x patch looks definitely RTBC to me.

The 7.x patch I realised I'm not sure how we're supposed to do 7.x-7.x update defgroups now (6.x had nearly all updates in system.install due to disabled modules fright), and I also couldn't believe we don't have one yet. Either way that also looks good but might want to leave it CNR/RTBC for D7 for a bit after 8.x commit just to thrash this out.

xjm’s picture

Tagging issues not yet using summary template.

plach’s picture

Issue tags: +Needs backport to D7

This is needed to go on in #1164852: Inconsistencies in field language handling, see #74.

Dries’s picture

Version: 8.x-dev » 7.x-dev
Issue tags: -Needs backport to D7

Committed to 8.x. Moving to 7.x.

droplet’s picture

Status: Reviewed & tested by the community » Needs review

Needs D7 reviews

catch’s picture

Status: Needs review » Reviewed & tested by the community

Looks great for D7 too.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

This looks good, but now that schema descriptions actually do something (show up in PHPMyAdmin and other tools), we should make sure we cover this with an update hook in 7.x.

webchick’s picture

Sorry, catch pointed out #10 has the update hook. The docblock comments look a bit off, though:

 /**
  * @} End of "defgroup updates-6.x-to-7.x"
+ */
+
+/*
+ * @defgroup updates-7.x-extra Extra system updates for 7.x
+ * @{
+ */
+
+/* @} End of "defgroup updates-7.x-extra"

Note the first chunk starts with /** and these new chunks don't. Let's get a quick patch that fixes that up and doesn't come with the -D7.patch extension so testbot can have a crack.

Caligan’s picture

Status: Needs work » Needs review
FileSize
1.77 KB

Updated, docblock fixed, go-go-gadget testbot.

catch’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Rock! Thanks a bunch.

Committed and pushed to 7.x.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Needs issue summary update

Automatically closed -- issue fixed for 2 weeks with no activity.