Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
{comment}.timestamp not exists anymore and changed to {comment}.changed
Comment | File | Size | Author |
---|---|---|---|
#19 | comment-1069080-19.patch | 1.77 KB | Caligan |
#10 | comment-1069080-10-D7.patch | 1.72 KB | Caligan |
#9 | D8comment.patch | 644 bytes | Caligan |
#7 | D8comment.patch | 643 bytes | Caligan |
#5 | D8comment.patch | 643 bytes | Caligan |
Comments
Comment #1
droplet CreditAttribution: droplet commentednew patch for D8 and same patch of D7 above.
Comment #2
Caligan CreditAttribution: Caligan commentedD8 patch looks fine. Revised the D7 patch comment_update number.
Comment #4
Caligan CreditAttribution: Caligan commentedOne the bot should ignore....
Comment #5
Caligan CreditAttribution: Caligan commentedExact replica of #1 patch, un-suffixed to kick the testbot.
Comment #7
Caligan CreditAttribution: Caligan commentedExact was the wrong answer... updated diff to tip of latest.
Comment #9
Caligan CreditAttribution: Caligan commentedComment #10
Caligan CreditAttribution: Caligan commentedWhitespace correction to D7 patch. Also defines defgroup updates-7.x-extra.
Comment #11
catchReviewed this with Caligan in irc.
The 8.x patch looks definitely RTBC to me.
The 7.x patch I realised I'm not sure how we're supposed to do 7.x-7.x update defgroups now (6.x had nearly all updates in system.install due to disabled modules fright), and I also couldn't believe we don't have one yet. Either way that also looks good but might want to leave it CNR/RTBC for D7 for a bit after 8.x commit just to thrash this out.
Comment #12
xjmTagging issues not yet using summary template.
Comment #13
plachThis is needed to go on in #1164852: Inconsistencies in field language handling, see #74.
Comment #14
Dries CreditAttribution: Dries commentedCommitted to 8.x. Moving to 7.x.
Comment #15
droplet CreditAttribution: droplet commentedNeeds D7 reviews
Comment #16
catchLooks great for D7 too.
Comment #17
webchickThis looks good, but now that schema descriptions actually do something (show up in PHPMyAdmin and other tools), we should make sure we cover this with an update hook in 7.x.
Comment #18
webchickSorry, catch pointed out #10 has the update hook. The docblock comments look a bit off, though:
Note the first chunk starts with
/**
and these new chunks don't. Let's get a quick patch that fixes that up and doesn't come with the -D7.patch extension so testbot can have a crack.Comment #19
Caligan CreditAttribution: Caligan commentedUpdated, docblock fixed, go-go-gadget testbot.
Comment #20
catchComment #21
webchickRock! Thanks a bunch.
Committed and pushed to 7.x.