When visiting the xmlsitemap settings page, the directory prefix shown for the xmlsitemap_path setting is incorrect when the default file scheme is set to private rather than public.

CommentFileSizeAuthor
#3 xmlsitemap_settings_form-field_prefix-1248084-3.patch1.13 KBpillarsdotnet
#2 xmlsitemap_settings_form-field_prefix-1248084-1.patch1.16 KBpillarsdotnet
#1 xmlsitemap_settings_form-field_prefix-1248084-1.patch0 bytespillarsdotnet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented
FileSize
xmlsitemap_settings_form-field_prefix-1248084-1.patch0 bytes

The attached patch ensures that the proper directory prefix is shown, regardless of the default file scheme.

pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented
Status: Active » Needs review
FileSize
xmlsitemap_settings_form-field_prefix-1248084-1.patch1.16 KB

Really, this time.

pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented
FileSize
xmlsitemap_settings_form-field_prefix-1248084-3.patch1.13 KB

Should have used file_default_scheme().

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue tags: +D7 stable release blocker
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

I actually decided to base this off using file_build_uri() without realpath involved as that's kind of what core does already.
http://drupalcode.org/project/xmlsitemap.git/commit/6f4b6f0

Automatically closed -- issue fixed for 2 weeks with no activity.