Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
With the current views implementation, it is not possible to bring in the webform submissions if your base table is either node or users.
Patch to follow...
Comment | File | Size | Author |
---|---|---|---|
#6 | 1258044-allow_other_base_fields-6.patch | 2.44 KB | derhasi |
#1 | 1258044-allow_other_base_fields-2.patch | 1.61 KB | travist |
Comments
Comment #1
travist CreditAttribution: travist commentedHere is the patch.
Comment #2
vernond CreditAttribution: vernond commented@travist - Shouldn't this be in the views issue queue? Your patch doesn't appear to changing any webform code.
Comment #3
travist CreditAttribution: travist commentedThis code is in the webform module, within the views folder.
Thanks,
Travis.
Comment #4
vernond CreditAttribution: vernond commented:-) Clearly I was at the end of a caffeine cycle!
Comment #5
dawehnerI don't think a implicit relationship is required here. A relationship is actually always what you want.
Comment #6
derhasi CreditAttribution: derhasi commentedWith dereine's comment I generated a new patch, removing the implicit reference, but adding a reverse relationship, so we have the control over what relationships are built.
Comment #7
derhasi CreditAttribution: derhasi commentedRelation to #591902: Views filter: webform submitted by current user, #957332: Determine whether webforms have been submitted using views? and #1159790: Matching results.
Comment #8
quicksketchThis new patch in #6 looks great to me, though I'd prefer another reviewer to check it out also.
Comment #9
dawehnerIn general this looks fine, but didn't tested it.
Comment #10
xlyz CreditAttribution: xlyz commentedusing it now.
please commit :)
Comment #11
quicksketchTested it out and it works as advertised. I can add a relationship from a "Webform submissions" view to both the parent Webform node and to the user who made the submission. I can do it the other way around and add a relationship to a "Webform submission" from either a node or user view. Looks good to me. Committed to both 3.x branches.
Comment #12
xlyz CreditAttribution: xlyz commentedcan you please add the -dev version to downloads?
Comment #13
derhasi CreditAttribution: derhasi commentedxlyz, you can use the "View all releases" link at the bottom of the project page, or when using drush,
simply enter
drush dl webform --select
.Comment #14
quicksketchI don't like -dev releases because then I start getting bug reports against -dev versions that some silly person downloaded "about 3 months ago" as bug reports. End-users should use stable releases. If they want to use a dev release, they should know how to download the dev release (per derhasi's instructions).