Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
theme_field_multiple_value_form() in field.form.inc duplicates the code to generate a form required marker, rather than using the theme system. This patch replaces the duplicate code with a theme system call.
Comment | File | Size | Author |
---|---|---|---|
#5 | theme_form_required_marker_field_form_inc-D7.patch | 753 bytes | Liam Morland |
theme_form_required_marker_field_form_inc.patch | 753 bytes | Liam Morland | |
Comments
Comment #1
franzThis seems very adequate. Not only it was duplicating, but also making it impossible to theme it.
Comment #2
Dries CreditAttribution: Dries commentedThis looks good to me; let's see if there is more feedback though.
Comment #3
aspilicious CreditAttribution: aspilicious commentedI found the implementation of the theme function
It's an exact copy so this is good to go.
Comment #4
sunNice catch. Looks safe to be backported to me.
Comment #5
Liam MorlandD7 version of the patch attached.
Comment #6
Dries CreditAttribution: Dries commentedThis patch does not seem to apply against 8.x:
Let's see what the test bot says in #5.
Comment #7
Liam MorlandThe patch in #5 is for Drupal 7. The patch in the original post is for Drupal 8.
Comment #8
franzpatch in #5 has '-D7' suffix, so it will be ignored by testbot. It's better re-submit it after successful commit of patch in the original bug.
Comment #9
Dries CreditAttribution: Dries commentedD'oh. Not sure how I overlooked the -D7 suffix.
I committed #5 to 7.x and the original patch to 8.x.
We should be all set now. Thanks for your help!