zen_process is called too early [#1168324]

I have a sub-theme which implements subtheme_preprocess_region(), and in there I add some classes to the classes array. However, these classes are not added to my region markup. I think it's because Zen does all it's stuff before my sub-theme adds these classes.

It appears that the functions get executed in the following order:

zen_preprocess
zen_preprocess_region
zen_process (this is where the classes array get joined)
subtheme_preprocess
subtheme_preprocess_region (this is where I'm adding the classes)

Based on how the same thing works for blocks, I would expect that the subtheme preprocess functions would execute before zen_process. Here's the order the block functions are executed:

zen_preprocess
zen_preprocess_block
subtheme_preprocess
subtheme_preprocess_block
zen_process
zen_process_block

Am I missing something? Is this by design, or should the subtheme region functions be called before zen_process?

Comment	File	Size	Author
#3	zen-zen_preprocess-called-too-early.patch	785 bytes	barraponto

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

maartenverbaarschot CreditAttribution: maartenverbaarschot commented 7 June 2011 at 20:18

Title:

Adding region classes

» Can't add classes in subtheme_preprocess_region()

I experienced this too. I don't think it's by design, as it does work as expected with node and block preprocessors. (Marked #1181184: zen_process() is called before mysubtheme_preprocess_region() as a duplicate of this issue)

Comment #2

barraponto CreditAttribution: barraponto commented 4 September 2011 at 13:42

Title:	Can't add classes in subtheme_preprocess_region()	» zen_process is called too early
Priority:	Normal	» Major

This is my first patch regarding the theme registry, so beware.

I noticed the process functions get called again later, when we loop through existing hook, so I guess we can safely remove from the array added by default to theme_region. Thus, when it gets added, all of the preprocess functions are already added.

I have changed the priority of this bug to major, since it breaks a d7 functionality Zen backports.

Comment #3

barraponto CreditAttribution: barraponto commented 4 September 2011 at 13:43

File	Size
zen-zen_preprocess-called-too-early.patch	785 bytes

Comment #4

barraponto CreditAttribution: barraponto commented 14 December 2011 at 22:47

Status:

Active

» Needs review

this is one of those days.

Comment #5

JohnAlbin

he/they/他

English

Taipei, Taiwan

CreditAttribution: JohnAlbin commented 21 August 2013 at 15:26

Component:	PHP code	» layout.css
Status:	Needs review	» Needs work

Comment #6

mvdve CreditAttribution: mvdve commented 18 April 2015 at 11:42

Issue summary:

View changes

I experience the same issue (i think... still not sure what is happening).
The preprocess function of my panels layout does not get run all the time. There is a static variable set within this function (with panels everywhere) and it is not always set. In this case, the complete preprocess function of the panels layout is not activated.