Fivestar error ResponseText: Fatal error: Call to undefined function fivestar_get_tags() breaks upgrade from D6

had that too when updating. copied the function into the *.installl for updating :)

Drupal 7 runs the install files even when a module is disabled.

I tried to fix this by adding module_load_include

function fivestar_update_7201() {
  module_load_include('module', 'fivestar');
  $fields = field_read_fields(array('module' => 'fivestar'));
  $tags_numeric = array_values(fivestar_get_tags());

Unfortunately it failed on the next update

Update #7203

    Failed: FieldException: Attempt to create a field of unknown type <em class="placeholder">fivestar</em>. in field_create_field() (line 106 of /home/iafmd/d7.iaf-methods.org/htdocs/modules/field/field.crud.inc).

So what I did was
1. move the fivestar module out of the drupal tree.
2. run update.php
3. move fivestar back into the drupal tree
4. enable fivestar
5. visit update.php again.

My guess is fivestar should add module_load_include('module', 'fivestar'); to update 7203. But that probably need more like a reload of the field definitions by a cache_clear_all(); ?

Marked #1336688: Fivestar breaks upgrade to Drupal 7 as a dupe of this.

Set to major as this is a pitb :(

I copied over the code from #1336688: Fivestar breaks upgrade to Drupal 7 thanks to SangersDrupalDude just as a reminder

/**
 * Fixes the axis value stored for fivestar fields
 */
function fivestar_update_7201() {

  include_once 'fivestar.module'; // added to make fivestar_get_tags available!!!!!!

  $fields = field_read_fields(array('module' => 'fivestar'));
  $tags_numeric = array_values(fivestar_get_tags());
 
  foreach($fields as $field) {
    if (is_numeric($field['settings']['axis'])) {
      $field['settings']['axis'] = $tags_numeric[$field['settings']['axis']];
    }
  }
}

today again :)
above code fixes that

patches are always welcome :)

This is now fixed.

--
http://drupalcode.org/project/fivestar.git/commit/3c34067

Sorry it took so long :)

it breaks on the module check:
1) enabled the module
2) commented out the include function

function fivestar_update_7201() {
//include_once 'fivestar.module';
  $fields = field_read_fields(array('module' => 'fivestar'));
  $tags_numeric = array_values(fivestar_get_tags());

3) ran update

drush updatedb
The following updates are pending:

fivestar module :
7203 - Convert all existing fivestarnode_type settings into fields with exposed fivestar formatters
7204 - Preserve settings from fivestar_formatter_exposed_stars and convert to fivestar_formatter_default.
7205 - Rename fivestar 'select' widget to 'fivestar_select' @see http:drupal.orgnode1285456

Do you wish to run all pending updates? (y/n): y
Performed update: fivestar_update_7203 [ok]
Performed update: fivestar_update_7204 [ok]
Performed update: fivestar_update_7205 [ok]
Finished performing updates. [ok]

Thanks for the great lead to solving this :)

add debug