Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
You can now enter an empty string for the name of the shortcut, this form element should be required.
Comment | File | Size | Author |
---|---|---|---|
#1 | 1271026-shortcut-empty-name-1.patch | 840 bytes | Sivaji_Ganesh_Jojodae |
shortcut-empty-name.patch | 467 bytes | swentel | |
Comments
Comment #1
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedswentel, I thought it would be great to set the title automatically when it is empty. The patch I have attached to this comment would do it.
Comment #2
Bojhan CreditAttribution: Bojhan commentedI dont think that's so great, because its magic and will confuse users who explicitly put in nothing. It should either be required, or not - autofill is a pattern we dont use anywhere else in core.
Comment #3
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedBojhan, I agree with you. Let's go with swentel's patch.
I see another misleading thing about shortcut, the enabled/disable rows in shortcut listing, see http://drupal.org/node/937380#comment-4949518. Wondering to know if anyone aware of what it could be.
Comment #4
Devin Carlson CreditAttribution: Devin Carlson commentedThe original patch by swentel looks good. The patch still applies cleanly with an offset.
This should be committed to both D8 and D7 as being able to create shortcuts is unexpected behaviour and it leads to confusion and accessibility concerns (shortcut links without names will still be output to the shortcut bar but they will be invisible except to people with screen readers who could be notified that there is a link but they will not know what it points to as it does not contain any text description).
Comment #5
Dries CreditAttribution: Dries commentedCommitted swentel's patch in #1 to 8.x and 7.x.