Attached

CommentFileSizeAuthor
#4 code_style_field_ui.test-1.patch1.13 KBChi
#1 code_style_field_ui.test-0.patch1.13 KBChi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Active » Needs review
FileSize
code_style_field_ui.test-0.patch1.13 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

Straight forward

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Needs work

While we're there could we remove this double space before the strtolower? Same thing appears each time.

+    $type_name =  strtolower($this->randomName(8)) . '_test';
Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs work » Needs review
FileSize
code_style_field_ui.test-1.patch1.13 KB
TR’s picture

TR CreditAttribution: TR commented
Status: Needs review » Reviewed & tested by the community

Looks good to me for both D8 and D7.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Version: 8.x-dev » 7.x-dev

Thanks! Committed and pushed. Moving to 7.x for webchick.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.