Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When visiting admin/config/system/cron the text reads "Cron takes care of running periodical tasks like checking for updates and indexing content for search." It should read "Cron takes care of running periodic tasks like checking for updates and indexing content for search."
Comment | File | Size | Author |
---|---|---|---|
#30 | misnomer-and-spacing-1251768-30.patch | 693 bytes | vegantriathlete |
#29 | D7-misnomer-and-spacing-1251768-29.patch | 693 bytes | vegantriathlete |
#23 | misnomer-and-spacing-1252768-23.patch | 692 bytes | vegantriathlete |
#22 | 1252768-22.patch | 691 bytes | ultimateboy |
#20 | 1252768-7.txt | 691 bytes | ultimateboy |
Comments
Comment #1
vegantriathleteDo you still do MTPOM? Enjoy!
Comment #2
vegantriathleteI guess patching D7 is a bigger issue than I thought, since it would require changing translations. Here is the patch rolled against D8. Do I get to be a core contributor for D8?
Comment #3
ultimateboy CreditAttribution: ultimateboy commentedSimple change for D8 to make this sentence grammatically correct. I would actually argue that backporting this to D7 does not break translations because I would hope that translators did not interpret this literally... and if they did, well, they should fix it too. But regardless, setting to rtbc for D8.
Comment #4
catchCommitted to 8.x.
This will break translations in the sense that the string change makes any translation outdated. However how frozen string freeze really is is under discussion in http://groups.drupal.org/node/154304
I'm not clear what the outcome of that is so moving back to 7.x for webchick to consider.
Comment #5
vegantriathleteThe backport already exists above.
Comment #6
webchickThe concatenation was off in the patch that was committed. Could that please be fixed? (there should be a space on either side of the . characters)
This is an actual bug fix in the string, so I think we could commit it to D7.
Comment #7
ultimateboy CreditAttribution: ultimateboy commentedSorry I missed that in the review. Here's a patch to fix the issue in D8. New patch coming for D7.
Comment #8
ultimateboy CreditAttribution: ultimateboy commentedAnd here's the patch for D7.
Comment #9
sreynen CreditAttribution: sreynen commentedBoth #7 and #8 look good to me.
Comment #10
sreynen CreditAttribution: sreynen commentedrfay suggested changing status to retry testing.
Comment #11
sreynen CreditAttribution: sreynen commentedOne more time?
Comment #12
sreynen CreditAttribution: sreynen commentedRe-queued, back to RTBC.
Comment #13
sreynen CreditAttribution: sreynen commentedSeems I broke the test system. Once more around the block.
Comment #14
sreynen CreditAttribution: sreynen commentedBack to NR.
Comment #15
rfaySorry for the pain.
Comment #16
rfayComment #17
rfayTrying again by re-uploading. Sorry
Comment #20
ultimateboy CreditAttribution: ultimateboy commentedLet's try re-uploading the D8 patch :)
Comment #21
ultimateboy CreditAttribution: ultimateboy commentedI never thought a patch that added a few spaces could be so difficult. These are ready to go, testbot is just having hiccups. Comment #7 is for Drupal 8, and Comment #8 is for D7.
Comment #22
ultimateboy CreditAttribution: ultimateboy commentedJust because I really want to see this turn green. This is for D8 once more.
Comment #23
vegantriathleteAnd here it is again for D7.
Comment #25
webchickThat test failure's ok, and to be expected. Unfortunately, testbot only knows to test one branch at a time, and the issue's currently on "8.x-dev" so the 7.x one will fail.
However, #22 was exactly what I'm looking for, thanks! Committed and pushed to 8.x.
Now let's try and move this back to 7.x and see what it thinks about #23.
Comment #26
webchick#23: misnomer-and-spacing-1252768-23.patch queued for re-testing.
Comment #28
vegantriathleteI'm rolling it again right now. Hold on.
Comment #29
vegantriathleteThis is getting ridiculous ;-)
Here it is again for D7 starting from the beginning. Let's hope it doesn't choke on the line endings.
Comment #30
vegantriathleteOkay, I guess I triggered the ignore by placing the D7 in front. Let's try it renamed.
Comment #31
webchickHeh, one other quirk of the testbot is that things need to be either "needs review" or "reviewed & tested by the community" for it to test them.
(Oh, the things you forget are utterly confusing until you need to explain them out loud. :D)
Comment #32
vegantriathleteWe'll still have to see what happens with EOLs (I'm doing this on Windows -- Don't have my Ubuntu machine fully set up, yet). When I set notepad++ to use Unix EOL's I get a warning from Git Bash about LF being changed to CRLF when I create the diff. So, I still may need to pull the patch back into notepad++ to convert the EOL's to Unix again.
Comment #33
webchickAh, yes. I remember that pain very well. :(
Good luck, my friend! May testbot bless your patches. :)
Comment #34
vegantriathlete@webchick: Once it passes, could you do me the favor of using
--author="vegantriathlete <vegantriathlete@491720.no-reply.drupal.org>"
on the commit. I'm desperate to actually have the commit show up under my Commits tab on my profile :-)Comment #35
vegantriathleteOkay, I'm going to meditate for one hour and I'll check back on this crazy testbot.
Comment #36
vegantriathleteSuccess! Let me know if you still need me to convert the EOLs.
Comment #37
webchickAwesome! :D
Committed and pushed to 7.x. Thanks.
And unfortunately, I'm not comfortable using Git's --author flag on core commits, because apart from more minor issues like this, there is almost no patch committed to core that's not a result of multiple peoples' work. It would be unfair to credit *one* person with 'first class' commit credit, at the expense of all the other people who also worked on an improvement.
There are folks working on improving this situation in the future; for example, moving to a model where each issue in the issue queue is a repository that anyone can commit to and maintainers would just merge the changes in, or using the Git 'notes' field as a means of adding additional credit to others.
But for now, I have to stick with the old crappy and legacy comma-separated names way, out of fairness. :)
Comment #38
vegantriathleteI understand your point about the credit. Even with this simple patch, ultimateboy helped out with your request for the proper spacing around the concatenation symbol.