avoid entity_load() during entity info cache rebuilds

Yep, this cache-rebuilding issue seem to pop up again and again. Even if uuid is able to workaround, let's try to break that ugly interdependency and follow core by avoiding the entity-info-alter hack and don't use entity_load() for getting bundle entities. E.g. core uses taxonomy_vocabulary_get_names() in taxonomy_entity_info() to bypass this issue. Bypassing entity-load() is not ideal and a hack too, but at least we can do a way with that inter/self-dependency causing weird issues.
As clean solution I think we should do hook_entity_bundle_info() as proposed in #1092192-24: Using hook_entity_info_alter to add the bundles prevents some modules from altering entities. But that's of course not on the table for d7.

However, in order for that to work with exportables we need to get #1267070: Lazy-rebuilding the defaults for exported entities might not be desirable in first. Given that, exportables should be synced already to the database when the cache is rebuilt during module installation (needs verification).

Then, once this works all the modules (Field collections, Profile2, Message and OG) need to be updated to follow that. Field-collection really is a separate issue though, as it makes use of field_info_field(), but we should be able to trigger entity-info-rebuilding there by fixing it to use field_read_fields().

adding tag

ok, here is a patch which remove the work-a-round from the entity api.

I don't think there is a hurry to commit this patch though, first modules that use bundle-entities like profile2, og and message should adapt.

attached are patches for profile2 and og.

@fago,
So I can already commit this to OG/ Message, or is the patch in #3 needed first?

Committing the patches now is fine, I've just committed the profile2 patch.

Committing #3 not now does no harm, moreover it requires all used contrib modules to be fixed. So let's postpone it for a while and make sure we fix all the contrib modules now.

Thanks Amitaibu for fixing og and message.

I've just fixed field-collection, see
http://drupalcode.org/project/field_collection.git/commit/a2214e9

Also fixed the testing module, the docs and created a change notification.

Let's commit #3 once beta11 is shipped.

Might be worth keeping in mind that the hook documentation could be updated to highlight this issue.

After this has been rolled out, of course.

Is there still a need for this patch?

What modules are we still waiting on?

#4: entity_cache_profile2.patch queued for re-testing.

Can this be related to realname module bug where after clearing the cache, list of all tokens are gone under realname admin page?

ok, there was plenty of time for the releases of the modules to ship. So I've committed #3.