Remove unnecessary hook_requirements in linkchecker.install [#1306498]

In the 7.x version of linkchecker.install, the hook_requirements returns a status message using "http requests". This looks like a copy of Drupal's own "HTTP request status" message from the system.install file.

Alsp, this causes a conflict with Drupal's message, which results in The copy in linkchecker conflicts with the Drupal message to overwrite it, causing a status message with erroneous "Array" text.

Comment	File	Size	Author
#8	remove-linkchecker-requirements-http-1306498-8.patch	1.43 KB	dergachev
#8
#1	linkchecker-1306498-1-remove_hook_requirements.patch	1.7 KB	arithmetric
#1
	linkchecker-status-array.png	23.78 KB	arithmetric

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

arithmetric CreditAttribution: arithmetric commented 11 October 2011 at 20:26

File	Size
linkchecker-1306498-1-remove_hook_requirements.patch	1.7 KB

Attached is a patch that removes hook_requirements() from linkchecker.install.

Comment #2

arithmetric CreditAttribution: arithmetric commented 11 October 2011 at 20:26

Status:

Active

» Needs review

Comment #3

hass CreditAttribution: hass commented 12 October 2011 at 22:56

Status:

Needs review

» Closed (duplicate)

Comment #4

hass CreditAttribution: hass commented 12 October 2011 at 23:15

#1165160: Same requirements breaks drupal core status page (overwrites 'http requests')

http://drupal.org/node/1271780#comment-5091094

Comment #5

arithmetric CreditAttribution: arithmetric commented 12 October 2011 at 23:28

Status:

Closed (duplicate)

» Needs review

I agree that it is a core bug that the system status page can be messed up if two modules use the same key.

However, since Drupal 7's system module includes a check for HTTP requests, linkchecker doesn't need to do the same thing. For the sake of coding simplicity, why not remove the duplication?

Comment #6

hass CreditAttribution: hass commented 13 October 2011 at 18:49

The status could have changed... that's why it tried again.

Comment #7

hass CreditAttribution: hass commented 13 October 2011 at 23:48

Status:

Needs review

» Closed (duplicate)

I remember the reason. I'd like to show a Linkchecker status message on status page. System module only says it cannot check update status and linkchecker need to tell it cannot check any link without http requests.

Comment #8

dergachev CreditAttribution: dergachev commented 22 July 2013 at 22:58

Version:	7.x-1.x-dev	» 6.x-2.x-dev
Status:	Closed (duplicate)	» Needs review

File	Size
remove-linkchecker-requirements-http-1306498-8.patch	1.43 KB

OK I mean no disrespect, but hass is almost certainly wrong on this issue.
As far as I can tell, the fact that linkchecker.install DUPLICATES code from system.install is logically wrong, and causes the following problems:

Status Report page rendering breaks (as per above screenshot)
unnecessarily repeated checks to see whether drupal can issue HTTP requests
warning: strcmp() expects parameter 2 to be string, array given in /var/shared/sites/muhc/site/modules/system/system.module on line 1159. when visiting Status Report page (at least in PHP 5.3)

It might be the case that hass may been trying to workaround something buggy about core's 'http request' check (which is indeed complex and potentially buggy), but this workaround is no way to deal with that!!

I've re-rolled the patch from #1 against 6.x-2.x-dev, which fixes the problems for me.

I also notice that the 7.x-1.x branch doesn't seem to have this requirement checking, so this really seems to be only a 6.x issue.