Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If you select spanish format, the module doesn't work because the regexp is wrong. I had change the regexp and now works with +xx xxx xxx xxx format and xxx xxx xxx format.
Attach the patch file.
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff.txt | 2.63 KB | jlbellido |
#11 | spanish_format_phone_patch_11.patch | 2.59 KB | jlbellido |
#1 | spanish_format_phone_patch.diff | 2.3 KB | javiferrer |
spanish_format_phone_patch.diff | 2.11 KB | javiferrer | |
Comments
Comment #1
javiferrer CreditAttribution: javiferrer commentedSorry, the previous patch has a mistake. Attach the correct patch.
Comment #3
syp CreditAttribution: syp commentedStill this problem isn't solved in dev release.
Confirmed this patch works, but with a minor issue:
When no international code is entered, a space is inserted at the beginning of the phone number.
Ex: " 699 699 699"
I solved it this way:
(Sorry I don't have a development site to create a patch)
Comment #4
warmth CreditAttribution: warmth commentedAfter applying this patch is needed this other: #1026708: Spanish phone CCK field removes content
Is this patch going to be committed?
Comment #5
warmth CreditAttribution: warmth commentedGuys why did you release a new version without fixing this?
Comment #6
cweagansWhat do you mean? We haven't released a new version.
rfsbsb is the new comaintainer of this module's 1.x branches. He was just given commit access a week or two ago. Please standby.
Comment #7
warmth CreditAttribution: warmth commentedFew days ago I was prompted to update the module and this fix was not included. That's all I mean.
Comment #8
Edgar Saumell CreditAttribution: Edgar Saumell commentedFYI: With 7.x-1.x-dev - 2013-May-25 I get this error:
Notice: Undefined offset: 3 in format_es_phone_number() (line 69 of .../sites/all/modules/phone/include/phone.es.inc).
Didn't tried any patches here.
Comment #9
cweagansResetting priority. This isn't critical.
Comment #10
sja1 CreditAttribution: sja1 commented# 3 worked for me, and I did not have to apply patch mentioned in #4.
And I would say it is a critical bug. All attemps to save a Spanish phone number throw an error.
For me this meant that I was unable to update any nodes that had a Spanish phone number field, as this field generates an error on save every time.
Comment #11
jlbellidoUpdate #1 patch with the sugested code in #3, this patch works for me and i didn't apply the patch mentioned in #4.
This should be critical because, phone numbers isn't saving.
Thanks to @javiferrer and @syp for their work.
Comment #12
jlbellidoAdded the interdiff of the previous patch, sorry for noise.
Comment #13
Barry_Fisher CreditAttribution: Barry_Fisher commentedPatch in #11 working for me.
Comment #14
milopca CreditAttribution: milopca at Òmada Interactiva commentedPatch in #11 working for me too.