While working on #1309392: Remove _form_set_class(), I noticed that we somehow missed a couple of these in node-rtl.css and in the Seven's CSS files. The original issue is here: #732914: Improve the markup/CSS for content and user filter forms. Here are the grep results:
Problem code
$ grep -r dl.multiselect .
./modules/node/node-rtl.css:#node-admin-content dl.multiselect dd .form-item label {
./themes/seven/reset.css:dl.multiselect dd,
./themes/seven/reset.css:dl.multiselect dd .form-item,
./themes/seven/reset.css:dl.multiselect dd select,
./themes/seven/reset.css:dl.multiselect dt,
./themes/seven/reset.css:dl.multiselect .form-item,
./themes/seven/style-rtl.css:dl.multiselect,
./themes/seven/style-rtl.css:dl.multiselect dt,
./themes/seven/style-rtl.css:dl.multiselect dd {
./themes/seven/style.css:dl.multiselect,
./themes/seven/style.css:dl.multiselect dt,
./themes/seven/style.css:dl.multiselect dd {
./themes/seven/style.css:dl.multiselect select,
./themes/seven/style.css:dl.multiselect dd select {
How to fix
- This code no longer exists in Drupal 7 or 8. It can be safely deleted, and backported to Drupal 7.
- The
#node-admin-buttons
was part of this, so the entire node-rtl.css should be deleted in this patch.
Comment | File | Size | Author |
---|---|---|---|
#3 | remove_multiselect_1311490_3.patch | 1.79 KB | skottler |
#1 | remove_multiselect_1311490.patch | 1.75 KB | skottler |
Comments
Comment #1
skottler CreditAttribution: skottler commentedI've attached a patch to remove all the instances of dl.multiselect.
Comment #2
JacineThank Sam!
Just gotta delete node-rtl.css cuz of this
#node-admin-buttons
(it's also gone), and this will be good to go!Comment #3
skottler CreditAttribution: skottler commentedI've attached the node-rtl.css file. This change is reflected in the new patch.
This patch also applies cleanly to D7 head.
Comment #4
JacineGreat, thanks Sam! Looks good.
Comment #5
Dries CreditAttribution: Dries commentedCommitted to 7.x and 8.x. Thanks! Good catch.