Notice: Undefined index: type in drupal_write_record() (line 6663 of /Users/dave/Sites/drupal-head/includes/common.inc).
Notice: Undefined index: type in drupal_write_record() (line 6700 of /Users/dave/Sites/drupal-head/includes/common.inc).

This is because $info['type'] does not exist on these fields.

CommentFileSizeAuthor
#17 998632-16.patch2.42 KBmcdruid
#17 998632-17_test_only.patch1.89 KBmcdruid
#16 interdiff-7_16.txt2.18 KBpoker10
#16 998632-16.patch2.42 KBpoker10
#7 998632_7_drupal_write_record.diff692 bytesdalin
#1 998632_1_drupal_write_record.diff1.32 KBdalin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
Status: Active » Needs review
Issue tags: +Schema API
FileSize
998632_1_drupal_write_record.diff1.32 KB

I believe this just needs a few isset($info['type']), but I'm not familiar enough with cross-db data types to know for sure.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Needs work

IMO we should look into why $info['type'] doesn't exist in the first place. I'd consider that a deeper bug. Really, isset() is a bad way to respond to undefined variables in a definition array. :-) Proper defaults are the right way.

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented

@crell most of the time I would agree with you. However I should have elaborated, this happens when you have a field something like this:

      'birthdate' => array(
        'description' => "YYYY-MM-DD formatted birth date.",
        'mysql_type' => 'DATE',
        'pgsql_type' => 'timestamp without time zone',
        'not null' => FALSE,
      ),

As I understand it, it isn't possible to come up with a value for 'type' in this case.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

I would just add a NULL 'type' in _drupal_schema_initialize().

jbrown’s picture

jbrown CreditAttribution: jbrown commented

The 'type' key is not optional.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

@jbrown: yes, it is.

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
Status: Needs work » Needs review
FileSize
998632_7_drupal_write_record.diff692 bytes

Added a NULL 'type' in _drupal_schema_initialize().

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

agree with the fix.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

This needs tests.

Vacilando’s picture

Vacilando CreditAttribution: Vacilando commented

Ran into the same problem, found this issue, applied dalin's patch from #7 and the notices disappeared.

j4’s picture

j4 CreditAttribution: j4 commented

works for me too..

Jaya

naringas’s picture

naringas CreditAttribution: naringas commented

Had this problem in 7.10 using my custom module code (which also has a schema like #998632-3: drupal_write_record() throws PHP notices if any fields use DB-specific data types).
I applied patch in my development server and it fixed the issue (after a cache flush).

Vacilando’s picture

Vacilando CreditAttribution: Vacilando commented

Bump. The patch in #7 has worked for me again, on a different system, in D7.14.

cjoy’s picture

cjoy CreditAttribution: cjoy commented

patch in #7 worked fine on 7.15, no more notices caused by the following schema field:

'createtime'                 => array(
        'description' => 'timestamp',
        'mysql_type'  => 'timestamp',
        'not null'    => FALSE,
      )
tonylegrone’s picture

tonylegrone CreditAttribution: tonylegrone commented

Adding a NULL type to hook_schema also fixed this bug for me without applying the patch.

      'valid_from' => array(
        'description' => 'The start date.',
        'type' => NULL,
        'mysql_type' => 'datetime',
      ),
poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
998632-16.patch2.42 KB
interdiff-7_16.txt2.18 KB

This is a bit old, but according to the schema documentation (https://www.drupal.org/docs/7/api/schema-api/schema-reference):

All parameters apart from 'type' are optional except that type 'numeric' columns must specify 'precision' and 'scale', and 'varchar' columns must specify 'length'.

According to this I think that it would probably be sufficient to update the schema documentation page to include an information, that if someone uses a DB-specific type, it is also needed to put a NULL to the type parameter (like it was mentioned in #15).

If we want to go the other way and add a "safety net" (see #7), then I have created a test for this. Reuploading the original patch (with slightly modified comment) with the test added. We will discuss which approach will be better in D7.

Just a note, _drupal_schema_initialize() was removed in D10, so we can proceed independently with this D7 issue.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid as a volunteer and at Acquia commented
FileSize
998632-17_test_only.patch1.89 KB
998632-16.patch2.42 KB

I think this looks good.

Here's a test-only patch.. I'll also re-upload the full patch from #16 so we can have the most recent patch passing.

The last submitted patch, 17: 998632-17_test_only.patch, failed testing. View results

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +RTBM

I'm happy to RTBC (/ RTBM) this as my last patch was just splitting out the tests to show that they fail in isolation.

  • poker10 committed 5a129b18 on 7.x 
    Issue #998632 by dalin, poker10: drupal_write_record() throws PHP...
poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -RTBM

Committed, thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.