Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton’s picture

Status: Active » Needs review
FileSize
719 bytes
msonnabaum’s picture

Status: Needs review » Reviewed & tested by the community

Agreed. Bunnies are clearly fuzzy.

Dave Reid’s picture

lol wut?

jenlampton’s picture

Title: Update test node content » Bunnies are fuzzy: update search test node content to reflect this.

Maybe a clearer title will help.

michaelfavia’s picture

@xjm might take issue with this one. http://drupal.org/user/65776 :)

michaelfavia’s picture

Apparently so does google autocorrect :(.

This is a travesty. Some one call the president of the internet .

http://www.google.com/search?&q=bunny+fuzzy

chx’s picture

bunnies are fluffy. A somewhat disgusting game for example lists it as a phrase. http://en.wikipedia.org/wiki/Chubby_bunny

chx’s picture

Status: Reviewed & tested by the community » Needs work

http://www.urbandictionary.com/define.php?term=Fuzzy%20Bunnies fuzzy bunnies is NOT going into core. I am happy to debate fluffy vs furry :D

chx’s picture

Title: Bunnies are fuzzy: update search test node content to reflect this. » Bunny ears are fuzzy: update search test node content to reflect this.
Status: Needs work » Reviewed & tested by the community

Well, ok , the patch actually is about the ear property of the bunny objects not the bunny class themselves. furry bunny ears finds less than half a million in google while fuzzy bunny ears has a million and a half.

seandunaway’s picture

s/were/are/

Xano’s picture

If all else fails, we can always resort to kittens.

DamienMcKenna’s picture

From a biological accuracy standpoint, this is an exceedingly important patch that fixes a gross inaccuracy thus must be applied immediately.

As @Xano optioned, if for some reason bunnies are no longer to be referenced, then the recommended replacement from a taxonomic perspective (meta data used for selection: small, cute, fuzzy, quantity-of-internet-memes, quality-of-internet-memes, is-a-cat) is "kittens", which also has "fuzzy" ears.

catch’s picture

Status: Reviewed & tested by the community » Needs work

The last submitted patch, update_search_node_test_content-1326932-1.patch, failed testing.

DamienMcKenna’s picture

If @chx's feedback is considered valid then perhaps we should consider moving to "fuzzy kittens"?

jenlampton’s picture

Status: Needs work » Needs review
FileSize
739 bytes

rerolled.

msonnabaum’s picture

Re-rolled with proper attribution.

jenlampton’s picture

trying with git format-patch instead :)

seandunaway’s picture

Re: #10: Why are the bunny's ears no longer fuzzy? :)

JohnAlbin’s picture

Status: Needs review » Reviewed & tested by the community

When the bunny was here, the bunny's ears were fuzzy. We don't need a novella in a Simple Test to explain why the bunny has departed. Perhaps it left for more carrot-laden gardens. Or perhaps it simply grew up.

Regardless if the patch rollers wish to get a new bunny whose ears are fuzzy, the Grammar Police approve this patch.

seandunaway’s picture

Don't be upset that you're in jeopardy of being outdone for the Trivial Patch of the Month Award™.

chx’s picture

You can't outdo a single period. This patch changes two letters and the semantical meaning of a word.

catch’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 8.x. Does this need backport?

seandunaway’s picture

Status: Patch (to be ported) » Needs review
FileSize
719 bytes
seandunaway’s picture

Whoops, here's the format patch like before.

jenlampton’s picture

Status: Needs review » Reviewed & tested by the community

Works for me :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs backport to D7

Ha. :) Ok.

Committed and pushed to 7.x. Thanks!

David_Rothstein’s picture

Jen, I really wish you would stop engineering for the 80%!

Although it's true that many bunny ears are fuzzy, others are DEFINITELY furry. In fact, it's even possible for the same bunny ear to be fuzzy in one part but furry in another, as I think can be clearly seen from these pictures.

I believe it's important that Drupal support all kinds of bunnies. I therefore propose this followup patch which will allow sites to decide for themselves.

xjm’s picture

I've been following this issue for awhile, and I think @David_Rothstein has finally identified a proper, robust solution. +1 for #28.

jenlampton’s picture

another layer of abstraction? *sigh*

seandunaway’s picture

'tis the drupal way.

Gábor Hojtsy’s picture

I'd also add that localization is still not used in this patch, which will surely upset those German bunnies (as linked by David).

Automatically closed -- issue fixed for 2 weeks with no activity.

Gaelan’s picture

Issue summary: View changes

Really? An alter hook, not a BunnyEarProcessor class?