Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I found this code in core/themes/seven/style.css.
ol.task-list li.done {
color: #393;
background: transparent url(images/task-check.png) no-repeat 0 50%;
color: green;
}
Comment | File | Size | Author |
---|---|---|---|
#1 | clean_up_css_in_seven-theme-1328378-0.patch | 364 bytes | Chi |
Comments
Comment #1
Chi CreditAttribution: Chi commentedComment #3
Chi CreditAttribution: Chi commented#1: clean_up_css_in_seven-theme-1328378-0.patch queued for re-testing.
Comment #4
Chi CreditAttribution: Chi commentedTagging for backport.
Comment #5
aspilicious CreditAttribution: aspilicious commented... I've seen these mistakes before...
note: #393 is kinda blue-ish
Comment #6
JacineNice catch. :)
Comment #7
webchickThis is tagged for backport to D7. Can you explain (or better yet, demonstrate with screenshots) what the visual effects of this patch are? And if there are none, explain why?
Comment #8
Jacine@webchick In the above code
color: green
is always used, because it comes last, so there's no visual change. #393 is also green (it's just a tad lighter). It's basically how CSS works. The browser renders the last property it understands. So, you could have 20 different colors defined and the last one will always win.The person who coded this was probably just playing around with colors and forgot to remove the first one. There are no visual changes and it would have no effect on themes that have overridden it or anything like that, so it's totally safe for backport to D7.
Comment #9
Chi CreditAttribution: Chi commentedNo visual effects. It just makes code clear.
Comment #10
webchickLOL. OMG I'm rusty with CSS. Duh. Thanks for pointing that out.
Committed and pushed to 8.x and 7.x. Thanks. :)