Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
the last comma in param list makes a syntax error
Drupal
.
formatPlural
(
1,
"Whitespace Call plural",
"Whitespace Call @count plural",
)
;
should be
"Whitespace Call @count plural"
Comment | File | Size | Author |
---|---|---|---|
#8 | 1334768-8.patch | 361 bytes | fietserwin |
#2 | trailing_comma-1334768-2.patch | 341 bytes | sawtell |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedYes it's true and it will fail on some browsers.
Can you make a patch?
Comment #2
sawtell CreditAttribution: sawtell commentedMy first patch, hope it does the job!
Comment #3
aspilicious CreditAttribution: aspilicious commentedYou have to set it to needs review to trigger the testbot.
Let's see if your patch gets accepted.
Thnx for making it!
Comment #4
Pasquallethanks
Comment #5
sawtell CreditAttribution: sawtell commentedAh yes, I missed that step. D'oh!
NP, hopefully the first of many ;)
Comment #6
webchickD'oh! Thanks a lot for the fix!
Committed and pushed to 7.x. :)
Comment #8
fietserwinError also appears in 8.x
Comment #9
fietserwinThi shas already been reviewed for D7, it is an extrmeley small and simnple change, no other changes in D8 are touching this (except the move to /core), so I guess this can be set to RTBC without additional reviews?!
Comment #10
aspilicious CreditAttribution: aspilicious commentedtrue :)
Comment #11
catchHmm not sure why this never got committed to 8.x in the first place, but committed/pushed to 8.x now.