Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
First of all, excuse my English.
If Taxonomy Image integration is on, then one more column (sixth) is added to the forum table, but number of columns in the table header remains the same (five). Because of it all captions shifted to wrong column. You can see results on attached screenshots.
Comment | File | Size | Author |
---|---|---|---|
#4 | table_header_colspan_for_taxonomy_image-1328152.patch | 952 bytes | mcdruid |
taxonomy_image_on.gif | 5.98 KB | RedRat | |
taxonomy_image_off.gif | 5.67 KB | RedRat |
Comments
Comment #1
MichelleHmm... I'm pretty sure this was fixed at one point. I remember the patch. Don't have time to test to see if it got reverted somehow, though.
Michelle
Comment #2
mcdruidI think this is probably the issue / patch you're thinking of Michelle: #1015118: naked style colspan bug with taxonomy_image module enabled
...however it looks like advanced_forum.naked.forum-list.tpl.php has changed a bit since then.
I'll have a proper look when I'm on my dev machine.
Comment #3
MichelleYeah, that's the one I'm thinking of.
Michelle
Comment #4
mcdruidRedRat, could you try this patch please?
Comment #5
RedRat CreditAttribution: RedRat commentedI have tried patch from #4 and it works fine. Just a little suggestion for it:
<th class="forum-icon"<?php if ($use_taxonomy_image) print ' colspan="2"'; ?>>
Comment #6
RedRat CreditAttribution: RedRat commentedBTW, is taxonomy icons have to be added to original forum icons, or have to replace them? Now I see two icons for every forum, one from original forum theme and another from taxonomy.
Comment #7
mcdruidThanks for testing RedRat, and yes your suggestion looks like it would work fine - I was trying to stay consistent with the code which does something similar a few lines further down in the same file.
I'll get the fix committed shortly.
As for removing the default icons, there are a few support requests about that in the queue - try searching for 'taxonomy image'.
e.g. #1221444: How to change category pictures like Coulee Region forums
Comment #8
mcdruidCommitted to 6.x-2.x
http://drupalcode.org/project/advanced_forum.git/commit/6b0ebe3