Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There should be tests for mongodb_watchdog.
[17:47] dereine: i am not sure whether we have tests for the dblog admin screen , if not then the work is instnatly reusable as a core test. if there is such a core test then that just needs to be adjusted
Comment | File | Size | Author |
---|---|---|---|
#3 | mongodb_watchdog-tests.patch | 27.65 KB | dawehner |
#2 | mongodb_watchdog-tests.patch | 26.64 KB | dawehner |
#1 | mongodb_watchdog-tests.patch | 21.36 KB | dawehner |
Comments
Comment #1
dawehnerTotally broken. Sadly currently together with parts of http://drupal.org/node/660460
Comment #2
dawehnerTo test this patch, apply first http://drupal.org/files/issues/mongodb_watchdog-capped.patch
Down to:
Comment #3
dawehnerTests are passing now, missing "feature" of the watchdog admin ui convertion.
TODO: Convert admin/reports/(not_found|access_denied) to mongodb_watchdog
Comment #4
dawehnerThis patch is sure togehter with the capped stuff.
Comment #5
Damien Tournoud CreditAttribution: Damien Tournoud commentedReassigning.
Comment #6
chx CreditAttribution: chx commentedI think I committed this :) I need to run 'em to see whether they pass :p commit early, commit often :D
Comment #7
fgmNo longer applies (CVS format ?)
Comment #8
fgmThe committed versions do not run currently.
The D6/D7 patches included in #1355808: Implement watchdog filter-on-insert in mongodb_watchdog include working tests for the new filter-on-insert feature.
Comment #9
fgmImprovement added: tests no longer choke on qa.drupal.org: they are bypassed when no connection is available, so qa can still check well-formedness but not waste resources on tests that can only fail.
Comment #10
mgifford@chx - did you commit this?
@fgm - Can we close this issue?
Comment #11
fgmWell, many of the module tests no longer pass on the current dev version : Entity Query, Field Attach, and Session Handling.
So, since this is a "Watchdog" issue, it's definitely "fixed" at this point. Another issue should address broken tests in other components.