This module has history and it shows. Here is the issue for all whitespace, coding standard problems and punctuation in docs.

No change in API, naming or anything. Only annoying EOL whitespace and EOF new line and maybe a full stop missing in comments and the like. The best patches are the one where a git diff --ignore-space-at-eol wouldn't show anything.

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Version: 7.x-3.x-dev » 7.x-2.x-dev
Status: Active » Patch (to be ported)

Just committed whitespace trim in 3.x. Diff is empty with -d option :) now we don't have to worry about editors trimming all whitespace on save.

here is the script i used :

#!/bin/sh
FILES=`find openlayers | grep -v .git | grep -v .idea`
for file in $FILES 
do 
  sed -i 's/ *$//' $file
done

I leave as to be ported for now if zzolo wants this in 2.x

das-peter’s picture

das-peter CreditAttribution: das-peter commented

*yay* Thanks & I would like to say goodbye to --ignore-space-at-eol in 2.x too :)

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Yeah, lets put this in 2.x.

I do have to admit, my editor, Coda is quick to leave whitespace. :(

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Patch (to be ported) » Fixed

committed to 7.x-2.x too :)

das-peter’s picture

das-peter CreditAttribution: das-peter commented

Awesome & thanks.
Makes patching & reviewing really more efficient :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.