Default CSS is not neutral enough and there's no classes for zebra-striping the tables under /user [#1368162]

the default css in uc_addresses.css introduces new line heights, font sizes, paddings.

borders and colours are easy enough to override, but the others can be a pain to reconcile with a custom theme and IMO they really should be inherited from the theme anyway, it's just a couple of tables after all.

"odd" and "even" classes for tables are pretty much a standard in Drupal world, so they should be pushed into the module too.

Comment	File	Size	Author
#1	uc-addresses-remove-javascript-1368162-1.patch	490 bytes	thedavidmeister
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

thedavidmeister CreditAttribution: thedavidmeister commented 12 December 2011 at 06:13

File	Size
uc-addresses-remove-javascript-1368162-1.patch	490 bytes

patch attached simply comments out the line containing drupal_add_css() that pulls in the offending styles.

Comment #2

MegaChriz CreditAttribution: MegaChriz commented 12 December 2011 at 08:33

I think just comment out loading the CSS is not the right solution. This way, the default address looks just like the others, while with the uc_addresses.css loaded it's more highlighted. Maybe you want to write patch that patches uc_addresses.css?

For adding the "odd" and "even" classes, you're (also) welcome to post a patch.

Comment #3

thedavidmeister CreditAttribution: thedavidmeister commented 12 December 2011 at 23:22

indeed, i've added it to the backlog of the project i need uc_addresses for but i was on deadline and had to kill the css fast.

I don't believe that my solution was the best, but i put the patch up so i could drop it in a make file :P

i think you could make any decision you want on how the default address could look "highlighted" and you'd screw with somebody's custom theme.

most modules that implement this level of theming (beyond simple things like bold and italic text) give you the option to select various themes, with one of course being "blank". That way the (developer) end user can see how the module was intended to look but they can also easily modify the theme for their use-case.

Comment #4

thedavidmeister CreditAttribution: thedavidmeister commented 13 December 2011 at 01:49

also, not sure why i called the patch "remove javascript", that's clearly wrong..

Comment #5

MegaChriz CreditAttribution: MegaChriz commented 13 December 2011 at 16:31

Status:

Active

» Postponed

O.K. You prefer to do me let the changes. That's okay, but then it will take a while as Ubercart Addresses 6.x-2.x has the most priority for me now.

About "screwing somebody's theme": this CSS file was already there when I took over this project. I have redesigned the CSS file for the 6.x-2.x version. Maybe you want to review the CSS file for the 6.x-2.x version and tell me if you have the same theme problems there?

Comment #6

thedavidmeister CreditAttribution: thedavidmeister commented 13 December 2011 at 23:57

"You prefer to do me let the changes." - Not sure what you mean by this?

I'm cool to make the changes required to fix this "properly" with the zebra striping as well, we've put it in our project backlog. I'll be honest though, it will be a while before we get back to this as the backlog is rather long atm.