#997648: drupal_http_request() always calls fread() one more time than necessary
#164365-12: drupal_http_request() does handle (invalid) non-absolute redirects (RFC 7231)
#205969-11: drupal_http_request() assumes presence of Reason-Phrase in response Status-Line
#371495: Error message from drupal_http_request() not UTF8 encoded
#193073-11: drupal_http_request - socket not initialized
#106506-8: drupal_http_request() does not handle 'chunked' responses - Make it support HTTP 1.1
#1096890-15: drupal_http_request should return error if reaches max allowed redirects
#875342-21: Guzzle should pick up X-Drupal-Assertion-* HTTP headers
#965078-31: HTTP request checking is unreliable and should be removed in favor of watchdog() calls
#336367: HTTP client should protect commas when folding (compatibility with legacy HTTP/1.0)
#45338: log fsockopen errors to watchdog
Comment | File | Size | Author |
---|---|---|---|
#11 | httprl-1320222-11.patch | 2.34 KB | mikeytown2 |
#9 | httprl-1320222-9.patch | 2.2 KB | mikeytown2 |
#8 | httprl-1320222-8.patch | 769 bytes | mikeytown2 |
#6 | httprl-1320222-6.patch | 1.21 KB | mikeytown2 |
#5 | httprl-1320222-5.patch | 1.04 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedThis patch is for #193073-11: drupal_http_request - socket not initialized
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedhttp://drupalcode.org/project/httprl.git/commitdiff/d616895ef9e10e3dd437...
http://drupalcode.org/project/httprl.git/commitdiff/fa3cdb5a6f9404bb138c...
#1 has been committed. Keeping open for other issues.
Comment #3
mikeytown2 CreditAttribution: mikeytown2 commentedPatch that is inspired by #164365-12: drupal_http_request() does handle (invalid) non-absolute redirects (RFC 7231)
Comment #4
mikeytown2 CreditAttribution: mikeytown2 commentedPatch that is inspired by #371495: Error message from drupal_http_request() not UTF8 encoded
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedpatch inspired by #205969-11: drupal_http_request() assumes presence of Reason-Phrase in response Status-Line
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedpatch inspired by #1096890-15: drupal_http_request should return error if reaches max allowed redirects
Comment #7
mikeytown2 CreditAttribution: mikeytown2 commented#3, #4, #5, and #6 have all been committed.
What's left:
#997648: drupal_http_request() always calls fread() one more time than necessary
#106506-8: drupal_http_request() does not handle 'chunked' responses - Make it support HTTP 1.1
#875342-21: Guzzle should pick up X-Drupal-Assertion-* HTTP headers
#336367: HTTP client should protect commas when folding (compatibility with legacy HTTP/1.0)
#45338: log fsockopen errors to watchdog
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedforgot a semicolon in one of the last patches that was committed. This patch has been committed.
Comment #9
mikeytown2 CreditAttribution: mikeytown2 commentedpatch inspired by #336367: HTTP client should protect commas when folding (compatibility with legacy HTTP/1.0)
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commented#9 has been committed and I've created #1357482: Handle chunked and compression.
Comment #11
mikeytown2 CreditAttribution: mikeytown2 commentedfollow up for #10 that fixes a php notice. This patch has been committed.