Currently displayed on teaser and node regardless of settings [#1139470]

Comment	File	Size	Author
#7	show_button_in_node_teasser-1139470-7.patch	887 bytes	wolmi

Comment #2

petednz CreditAttribution: petednz commented 31 May 2011 at 04:28

Status:

Active

» Needs review

hi - can you clarify if this issues is about the 'Full View' versus "Teasers' settings - or is that when setting for node types here admin/config/tweetbutton/node it seems to me that regardless of setting Tweet to be unchecked for several content types, new content of that type ends up with a Tweet button when I don't expect it. Happy to make a new ticket if yours is 'teaser and node' settings rather than 'teaser or node' settings ;-)

Log in or register to post comments

Comment #3

realityloop

he/him

CreditAttribution: realityloop commented 1 June 2011 at 05:54

Hi Peter.. I can't remember to be honest. :)

From memory, the problem that my change fixed was to only display the tweet button on node types it was set for, previously it output on all node types I think.

Log in or register to post comments

Comment #4

petednz CreditAttribution: petednz commented 7 July 2011 at 23:17

i think i agree - but i hoped it may also resolve fact that the tweet button is coming through on Teasers - whereas Facebook like doesn't - but guess I will trawl the issues queues - though may both are working as intended - they just have different starting points

Log in or register to post comments

Comment #5

protools CreditAttribution: protools commented 16 August 2011 at 10:52

sub

Log in or register to post comments

Comment #6

BenK CreditAttribution: BenK commented 18 August 2011 at 01:10

Subscribing

Log in or register to post comments

Comment #7

wolmi CreditAttribution: wolmi commented 24 October 2011 at 20:34

File	Size
show_button_in_node_teasser-1139470-7.patch	887 bytes

The solution proposed on #1 is not exact.

I posted this patch on http://drupal.org/node/1272424 but I think is better to post here.

the result will look like this:

/**
 * Implementation of hook_node_view()
 */
function tweetbutton_node_view($node, $view_mode) {
$type = variable_get('tweetbutton_node_types', array('article' => 'article'));
  if(isset($type[$node->type]) && $type[$node->type] !== 0
    && in_array($view_mode, variable_get('tweetbutton_node_location', array('full')))
    && user_access('access tweetbutton')) {

    drupal_add_js('http://platform.twitter.com/widgets.js');
    drupal_add_css(drupal_get_path('module', 'tweetbutton').'/tweetbutton.css');

    // @todo: Add support for token replacements
    $token_replacements = array(
      '!title'        => $node->title,
      '!author_name'  => $node->name,
      '!node_type'    => $node->type,
      '!node_url'     => url('node/'.$node->nid, array('absolute' => TRUE)),
    );

          $node->content['tweetbutton'] = array(
      '#tokens'   => $token_replacements,
      '#weight'   => variable_get('tweetbutton_node_weight', -5),
      '#theme'    => 'tweetbutton_display',
    );
  }
}