The following warnings appeared after updating to D7.9 from D7.8 and only if the file field is attached to a field collection -- I debated adding the issue to the contrib module but the error is being reported by the file module and error/warning was not present in D7.8.
Full Error Message:
Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 753 of F:\web4\d7test2\modules\file\file.field.inc).
Warning: array_values() [function.array-values]: The argument should be an array in file_field_widget_submit() (line 760 of F:\web4\d7test2\modules\file\file.field.inc).
Does not occur if you have the file field attached straight to a content type - appears to only occur if attached to a field collection. The # of values for both the field collection and the file field were set to 1 - single instance only.
Does not occur if you add the file and submit the form - only if you use the upload button and form is rebuilt.
Occurs when adding new node or editing existing node.
I could upload a patch that adds logic to test for a valid array before the foreach loop at line 753 but was not sure if there is a deeper issue here - please advise as I'd be pleased to submit my first core patch if it's that easy :)
Comment | File | Size | Author |
---|---|---|---|
#65 | error_messages.png | 61.73 KB | weri |
#46 | issue_1329856.patch | 853 bytes | serbanbjd |
#38 | issue_1329856_1.patch | 629 bytes | jec006 |
#34 | issue_1329856.patch | 651 bytes | marco.pagliarulo |
#11 | issue_1329856.patch | 1.4 KB | blainelang |
Comments
Comment #1
stanuk0z CreditAttribution: stanuk0z commentedsubscribe
Comment #2
aspilicious CreditAttribution: aspilicious commentedI still think this is a field_collection issue passing the wrong arguments to the function
Comment #3
marcingy CreditAttribution: marcingy commentedIf the widget works correctly in the context of core then it has to be the contrib menu that is at fault, moving to the appropriate queue
Comment #4
jamesdixon CreditAttribution: jamesdixon commentedIt seems the drupal_array_get_nested_value is failing to get the submitted values. This is returning NULL which is hanging everything up (line 752 of modules/file/file.field.inc):
I'm not sure how drupal_array_get_nested_value works, but it seems like the nested parent keys don't exist.
For me, $form_state['values'] was:
And the second argument array_slice($button['#array_parents'], 0, -2) was:
Is $form_state['values'] not being set correctly?
Comment #5
jherencia CreditAttribution: jherencia commentedI don't have field collection module and I have the same problem.
I have a custom module to group some fields into fieldsets, I assume field collection does something similar, but I think its some kind of change in Form API in D7.9 that breaks this functionallity and possibly others.
Comment #6
indigoblue CreditAttribution: indigoblue commentedI am seeing the same problem when upgrading to 7.9. There appears to be a mismatch in the data going into the drupal_array_get_nested_value on line 752 file.field.inc.
The form_state values are...
and the $button['#array_parents'] values are...
I am not very familiar with the drupal_array_get_nested_value() function, but the second parameter should be an array of parent keys. The slice removes the last two keys to provide the parent keys. BUT it looks like that does not match what is in the $form_state['values'] array. So either the $form_state['values'] or the $form_state['triggering_element'] array is being incorrectly set. The $form_state['values'] look like they have been flatened.
By fixingup the $button['#array_parents'] to accurately match up with the $form_state['values'] as a quick work-around - the errors messages went away and things seem to be working.
Hope this helps towards a fix!
Comment #7
redhoodie CreditAttribution: redhoodie commentedsubscribe
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedPerhaps I'm a little dense, but I can't quite work out what you've done and where. I can't find any code like that in my file.field.inc file. Could you expand on your solution a little bit? Maybe a quick patch?
Thanks!
Comment #9
indigoblue CreditAttribution: indigoblue commentedI think @blainelang has a patch coming.
The code you will see at file.field.inc /modules/file/file.field.inc 752 is
As a TEMPORARY fix that worked for me, I replaced the second parameter of drupal_array_get_nested_value with a different way of calculating the parent keys. As @blainelang pointed out, changes here may have unwelcome effects elsewhere - but it worked for me.
Comment #10
arbel CreditAttribution: arbel commentedI'm having the same problem but my $form_state['values'} looks like an imploded array:
Array ( [profile_designer_field_designs_und_0_field_image1_und_0_upload_button] => Upload not a flattend one.
what could cause this?
Idan
Comment #11
blainelang CreditAttribution: blainelang commentedAttached is a patch that adds a test for a valid array before trying to process $submitted_values. This removes the warnings in my use-case and the file widget uploaded the file successfully.
Comment #12
tim.plunkettThat patch is against core, but this issue is still against field_collection.
Comment #13
blainelang CreditAttribution: blainelang commented@tim: understand, but I submitted this issue against core and did not change it to field_collection. This issue is appearing in other modules as noted by the other comments.
Comment #14
tim.plunkettComment #15
indigoblue CreditAttribution: indigoblue commentedI have tried the patch in #11 but experienced an issue. With the patch applied I am unable to "remove" an image. Anyone else seeing this?
Comment #16
arbel CreditAttribution: arbel commentedI've applied and still getting the result in #10
Comment #17
indigoblue CreditAttribution: indigoblue commentedI've had to revert to my last version (7.7). The 7.9 version completely breaks image processing ( and presumably other sites that may rely on file uploads ) - including sites that have been previously working well. The problem does not show in a simple clean install however. This is show-stopper for anything other than the most basic site and my concern is that this bug may not get fixed before the next release. I have therefore upped the priority.
Comment #18
catchThis was last changed in #1059268: Files are lost when adding multiple files to multiple file fields at the same time.
If that patch introduced a regression, then we need a test to catch that regression.
The patch here is doing unnecessary checks for count($array) -> 0. If an array is empty, then foreaching over it does nothing.
How are we ending up with an invalid array there? Is that a bug in field collection?
Comment #19
knalstaaf CreditAttribution: knalstaaf commentedConfirming that the patch provided in #11 doesn't help unfortunately. I'm using it with the latest version of D7.9 and the Field Collection 7.x-1.0-beta2.
Comment #20
Tony Finlay CreditAttribution: Tony Finlay commentedThe patch in #11 has solved any issues I was experiencing.
I'm currently using Field Collection 7.x-1.x-dev and core 7.9.
Comment #21
josebc CreditAttribution: josebc commentedim having the same problem, found it in both 7.8 and 7.9 core
Comment #22
knalstaaf CreditAttribution: knalstaaf commentedConfirming #20: it does work with Field Collection 7.x-1.x-dev (13 nov 2011).
Minor remark: it doesn't automatically upload the selected image when you hit "Add item" button. You either have to hit the "Upload" button right after you selected the file, or immediately save the node.
Comment #23
arbel CreditAttribution: arbel commentedlatest field collection patch doesn't work,
I get this message:
Warning: array_values() [function.array-values]: The argument should be an array ב-file_field_widget_submit() (\modules\file\file.field.inc).
Idan
Comment #24
knalstaaf CreditAttribution: knalstaaf commentedIdan, what version of Drupal and Field Collection are you using? Note that it's working on the configuration mentionned in #20.
Comment #25
arbel CreditAttribution: arbel commented7.9 and latest dev (from today).
$submitted_values is an empty array when dsm'ing right before $submitted_values = array_values($submitted_values);
Image uploads ok, if I hide the warnings, it works fine.
Comment #26
indigoblue CreditAttribution: indigoblue commentedJust as a heads-up. Whatever is happening in Field Collection is certainly just a symptom. I am experiencing these problems and do not have Field Collection installed.
Comment #27
scottrouse CreditAttribution: scottrouse commentedIt's a bit unclear to me from this thread where the issue exists (core vs. field_collection). I was experiencing this issue with drupal-7.9 and field_collection-7.x-1.0-beta2. Updating field_collection to 1.x-dev resolved the issue for me.
So, is this still an active issue? If so, is it a core issue or should it be a field_collection resolved/patched issue?
Comment #28
jec006 CreditAttribution: jec006 commentedI am still experiencing these same warning using Image fields in a field collection - the image / file upload does work, however, these warnings appear.
Perhaps the submit handler is getting called twice? Will investigate further.
versions are:
7.9 for drupal core
7.x-1.x-dev (2011-Nov-15) for field_collections
Comment #29
Tony Finlay CreditAttribution: Tony Finlay commentedHave you used the patch in #11?
Comment #30
jec006 CreditAttribution: jec006 commentedNo, I did not use the patch, was simply stating that with the latest version of the module, this issue still exists. (edit: in re scott)
Comment #31
scottrouse CreditAttribution: scottrouse commentedOk. Again, for me field_collection dev (Nov 15) along with drupal 7.9 resolved the issue without the patch. That, of course, doesn't mean it's fixed for everyone. Actually, after reading back through the issue, I'm afraid to test it again lest my issue return.
Comment #32
marcingy CreditAttribution: marcingy commentedMoving back to field collection as this does not seem like a core issue
Comment #33
josebc CreditAttribution: josebc commentedThe patch in #11 has solved the issues with Field Collection 7.x-1.x-dev and core 7.9.
but still having the problem in #22 , does anyone have a solution for this one?
Comment #34
marco.pagliarulo CreditAttribution: marco.pagliarulo commentedThe problem it's on the row 984 in field_collection.module. In the hook field_collection_field_widget_embed_validate if submitted data pass validations the content of form_state['values'][] is replaced with the entity, so it is saved with the host entity via hook_field_presave(). In the next pass the form submit handlers don't find the value in form_state becouse this is overwritten.
The solution is replace
if ($form_state['submitted'] && !form_get_errors() ) {
with
if ($form_state['submitted'] && !form_get_errors() && $form_state['clicked_button']['#name'] == 'op') {
Drupal core: 7.9
Field Collection 7.x-1-0-beta2
Comment #35
bxCreative CreditAttribution: bxCreative commented#34 worked for me.
Drupal core: 7.9
Field collections: 7.x-1.x-dev
Comment #36
mrsimonelliott CreditAttribution: mrsimonelliott commented#34 worked for me.
Drupal core: 7.9
Field collections: 7.x-1.x-dev
Comment #38
jec006 CreditAttribution: jec006 commentedAwesome, thank you so much Morpheus80ta
I simply rerolled the fix in #34 (which also worked for me) and made it apply against dev and be from the module root so it will hopefully pass testing and we can get it applied.
This fixed the errors that were showing on image upload for me
Comment #39
jec006 CreditAttribution: jec006 commentedmarking for test scripts
Comment #40
mrsimonelliott CreditAttribution: mrsimonelliott commentedThe patch in #38 solves the original problem on entities which only have image/file fields which are contained in field collections. However a new error message is invoked if your entity has a regular (not in a field collection) file/image field AND a file/image field contained in a field collection. See skitch for clarification of field/field collection config.
Error msg:
Notice: Undefined index: display_field in file_field_widget_value() (line 578 of .../www/modules/file/file.field.inc)
https://skitch.com/mrsimonelliott/gqdau/field-collection-issue
Comment #41
gagarine CreditAttribution: gagarine commentedPatch #38 doesn't work if you use the "upload" button of the image widget before you submit the node.
Comment #42
Cyclonecode CreditAttribution: Cyclonecode commentedPatch #38 solved the problem with field_collection 7.x-1.0-beta2, thank you very much=)
Comment #43
martysteer CreditAttribution: martysteer commentedSame here. Patch #38 solved the problem.
Comment #44
bryancasler CreditAttribution: bryancasler commented#38 worked, but still having the problem described in #40
Comment #45
pivica CreditAttribution: pivica commentedPatch from #38 worked for me nicely. I am only not very happy with using
$form_state['clicked_button']['#name'] == 'op'
for testing is form is really submitted or we are just in some ajax event, but I was not able to find some better condition for this check. Note that this condition will be true also if user hit preview or delete button - not sure should this code execute on this two submit events.
I then tried different combination of #40 - regular image field and image field in field collection, but I was not able to get error message from #40. I am using D7.10 and latest field_collection dev version.
Additional note, while testing I found one more bug, if you add image in collection and try to hit preview you will get new error message
and image from field collection will not be rendered. But this is completely unrelated problem with this issue and is definitely not a major bug.
Comment #46
serbanbjd CreditAttribution: serbanbjd commentedthis fixed the warnings in file_field_widget_submit. i was able to upload/remove file in field collection.
this is my first patch upload, so be gentle if i actually screwed things.
Comment #47
gagarine CreditAttribution: gagarine commentedComment #49
tim.plunkettThose patches are against core. Please set to needs review once there is a patch for this module.
Comment #50
perisdr CreditAttribution: perisdr commentedDoes 7.x-1.0-beta3 vesrion contain a fix for these warnings? I removed and did a fresh install of the module but the warnings persist. I have a simple field collection containing an image field and a text field. When uploading an image I keep getting
Comment #51
rich.3po CreditAttribution: rich.3po commentedGetting the same behaviour as in #50. Using version 7.x-1.0-beta3
Comment #52
echoz CreditAttribution: echoz commentedNothing here has been committed. Reports about patches are where individuals have applied them to test.
Comment #53
inventlogic CreditAttribution: inventlogic commentedThis error occurs in Taxonomy Manager if you add an image field to a vocabulary. So it is not an issue solely linked to field_collection. It occurs if you try to upload the image or remove the image using the Upload and Remove buttons. So it may be linked to how these button actions are defined in the image widget.
It does not happen if you select the image using the Browse button and then click the Save Changes button.
It does not happen when using the core taxonomy editing form.
Comment #54
jec006 CreditAttribution: jec006 commentedPlease go back to looking a the patch in #38 It is against field_collections. Apparently its not 100% but is a start. Getting sidetracked by patching core again seems less than ideal.
Comment #55
jec006 CreditAttribution: jec006 commented#38: issue_1329856_1.patch queued for re-testing.
Comment #56
tim.plunkettNo use in retesting something that has no tests. Maybe writing a test? What is
$form_state['clicked_button']['#name']
when this breaks?Comment #57
jec006 CreditAttribution: jec006 commentedSorry - Was just re-queueing to shift attention back to fixing field collections.
It appears that the validate function gets run when the upload button is clicked. Data is missing from the form at this stage in the form_state, it only includes very specific data for the submission of the file/image field. It seems like there should be some better clue to handle the submission differently ... but I don't see it.
The value for clicked button will be something like:
field_collection_gallery_und_0_field_main_image_und_0_upload_button
in this situation.I don't think this patch is 100%. It seems like there are some remaining issues that need work.
Comment #58
dedalu CreditAttribution: dedalu commented#38 manually patched against 7.x-1.0-beta3 works for me. I have a normal field and fields inside collections in the same entity, like #40, but no issues.
Comment #59
tim.plunkettEither needs some good docs, a test, or both.
Comment #60
alexdmccabeIgnore, my issue was due to a custom module.
Comment #61
shendric CreditAttribution: shendric commentedWould someone be able/willing to summarize what could be done for this error? I'm seeing a lot of patches, but I'm not sure which one(s) to use to fix this error. Could anyone advise? I'm on the latest core 7.12 and 7.x-1.0-beta3 of Field Collection. Should I install the dev version of Field Collection? Try one of the patches, perhaps #38?
Comment #62
anandkp CreditAttribution: anandkp commentedWarning:
Am a total Drupal NOOB Dev... hope my input helps!
Setup:
Drupal 7.12, Field Collection 7.x-1.0-beta3
Error:
Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 760 of /mnt/www/docroot/modules/file/file.field.inc).
Warning: array_values() [function.array-values]: The argument should be an array in file_field_widget_submit() (line 767 of /mnt/www/docroot/modules/file/file.field.inc).
Error occurs after uploading using the Upload btn in an image field.
File uploads correctly and on saving the node using the Field Collection, the image is viewable correctly.
Would be great to not have the warning though. I see that patch #38 has passed. Am gonna try applying it and will edit this comment with my results.
Subscribed :o)
Thanks to the maintainers of the module!
________________________________________________________________________________
One further note that might be helpful. The Warning is not appearing on my local development environment (WAMP 2.1, PHP error_reporting = E_ALL | E_STRICT) but on my remote integration environment (hosted by Acquia).
________________________________________________________________________________
UPDATE:
Applied the patch and it has corrected the error.
Thanks to the patch contributor!
Comment #63
myliefie CreditAttribution: myliefie commentedSet up: D7.12, Field collection 7.x-1.0-beta3
I'm having the same issue as discussed above:
Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 765 of D:\Websites\testsite\modules\file\file.field.inc).
Warning: array_values() expects parameter 1 to be array, null given in file_field_widget_submit() (line 772 of D:\Websites\testsite\modules\file\file.field.inc).
I tried the patch but unfortunately did not resolve the issue.
Comment #64
rafinskipg CreditAttribution: rafinskipg commented#38 worked for me with 7.x-1.0-beta3 field collection and Drupal 7.12.
I have to say tha i Had the same error than #62
Comment #65
weri CreditAttribution: weri commentedI believe this is a core file/file-widget issue and not an field collection issue. I got this error messages also when i add a nested file field to a form (attaching entity fields to a existing form). The error also occurs when i try to remove the image.
Comment #66
pelicani CreditAttribution: pelicani commentedapplied patch in #46 but still get the warning message.
I added an extra condition to check the count of the submitted_values array.
The error disappeared.
This probably isn't the right solution, but it works...
Comment #67
altrugon CreditAttribution: altrugon commentedI hope a patch for this come out soon, I'm experiencing the same problems and although my images get rendered the attributes alt and title are not and I totally need them for this project.
Comment #68
fakingfantastic CreditAttribution: fakingfantastic commentedDid some debugging on this: http://pastie.org/3541728
Looks like the issue is that Field Collection isn't setting up the proper $form_state['values'] .
Comment #69
njcheng CreditAttribution: njcheng commentedJust want to reference #1468686: file_field_widget_submit(), file.field.inc using the wrong parent key that is likely related and seems to use the method employed in #66.
Comment #70
antoniopironti CreditAttribution: antoniopironti commentedsubscribe: same issue for me.
Comment #71
LexusIrus CreditAttribution: LexusIrus commentedComment #72
tim.plunkettThere have been no new patches since #59.
Comment #73
jjjames CreditAttribution: jjjames commentedSubscribe
Comment #74
willhowlett CreditAttribution: willhowlett commentedPatch at #38 seems to have fixed the problem for me
Comment #75
damiandab CreditAttribution: damiandab commentedfor me also patch at #38 fixed the problem, thanks
Comment #76
antoniopironti CreditAttribution: antoniopironti commentedPatch at #38 fixed the problem for me too. Thank you very much.
Comment #77
Dante Taylor CreditAttribution: Dante Taylor commented#38: issue_1329856_1.patch queued for re-testing.
Comment #78
spiritfelix CreditAttribution: spiritfelix commented#38 issue_1329856_1.patch is worked for me. thx!
Comment #79
wouterb038 CreditAttribution: wouterb038 commented#38 issue_1329856_1.patch is worked for me 2...
THANKSSSSSSS
Comment #80
Josh Benner CreditAttribution: Josh Benner commentedPatch from #38 eliminated the error.
Comment #81
tim.plunkettAs was suggested in #66 and pointed out in #69, #1468686-8: file_field_widget_submit(), file.field.inc using the wrong parent key fixes this issue.
Comment #82
WilliamB CreditAttribution: WilliamB commentedSorry for reopening that bug Tim, but i've some extra information about it.
I'm using field collection and File Field Sources. To allow the user to select an image through IMCE (to avoid reuploading several time the same image).
I was facing an issue where i had a field collection containing an image field.
It worked fine for the inital image selection. However if i picked an image, removed it, and tried to pick another through imce, nothing would happend. If i tried to repick an image through the default upload i would get the error messages that were posted above.
As you suggested i applied the patch from #1468686-8: Array error in file_field_widget_submit(), file.field.inc, which fixed the error message and made the default upload work after an image was removed.
BUT it still didn't work when i tried to use IMCE after an image was removed. Applying the patch from 38 fixed that problem though.
So you might want to commit it to field collection.
Comment #83
acbramley CreditAttribution: acbramley commentedConfirming patch #38 fixed the issue for me too, and from the edge case explained above, it sounds like a valid thing to commit.
Comment #84
limptimtim CreditAttribution: limptimtim commented#38: issue_1329856_1.patch queued for re-testing.
Comment #85
dmcdenissen CreditAttribution: dmcdenissen commentedThe patch fixes the error but wenn you have a image field in this content-type the image field upload fails.
Comment #86
stred CreditAttribution: stred commentedPatch #38 fixes the errors for me even for images with beta4 version ...
Comment #87
pacome CreditAttribution: pacome commentedSame for me : patch #38 fixes the errors with beta4
thanks!
-p-
Comment #88
GaneshKumar CreditAttribution: GaneshKumar commented#38 works for me too... Thanks.
Comment #89
bryancasler CreditAttribution: bryancasler commentedComment #90
tim.plunkettOkay, committed. http://drupalcode.org/project/field_collection.git/commit/96eff7c
Comment #91
seanberto CreditAttribution: seanberto commentedThank you!
Comment #92
litvinova_yana CreditAttribution: litvinova_yana commentedThanks!
I did not want to hack modules, but I can't see another way still(
And how do you think, tim.plunkett, will this bug be corrected in the next version of Field collection?
Comment #93
tim.plunkettThis is already in the current dev release. It will therefore be in the next tagged release as well.
Comment #95
fagohm, that assumes the button has to be named 'op' - or it would skip validation. If an entity form has a different named button, validation would be skipped - *ouch*. Let's better revert this and a better solution.
I'm not sure which button click we have to void validating on, but the correct fix must be something else.
Comment #96
fagoAs this his possibly security implications I've reverted it. Let's try to come up with a proper solution.
Are the remaining problems related to images only? Then, the image related issue might have a solution: http://drupal.org/node/1545584#comment-6148300
Comment #97
star-szrThe patch at #1545584-14: Problem when using Image field with field collection fixes this issue for me.
Comment #99
David Vespoli CreditAttribution: David Vespoli commentedConfirming Patch #38 fixed errors with 7.x-1.0-beta4
Comment #100
jimmb CreditAttribution: jimmb commentedWith Drupal 7.15 and Field collection 7.x-1.0-beta4 ...
I've created a Field Collection with a generic file upload and a text field. When I upload a file, I'm getting these errors:
It appears there are 2 issues that seem to be relevant: This one and this issue. So I'm not sure whether to apply the patch in comment 38 from this thread, or from comment 27 in the other thread.
Comment #101
star-szr@jimmb, try the dev release of Field collection, it now contains the patch I mentioned in #97 and may fix your issue.
Comment #102
jimmb CreditAttribution: jimmb commentedThanks Cottser. I upgraded to the dev version, and that did fix the problem for me.
Comment #103
jimmb CreditAttribution: jimmb commented- duplicate comment removed by author -
Comment #104
isabel1991_17 CreditAttribution: isabel1991_17 commentedvery good the #38
thanks for the patch worked excellent
code helped me a lot
Comment #105
viseser CreditAttribution: viseser commentedPatch #38 solved the problem with field_collection 7.x-1.0-beta4,
thanks jec006 !!!
Comment #106
schweboo CreditAttribution: schweboo commented#38: issue_1329856_1.patch queued for re-testing.
Comment #107
josegaert CreditAttribution: josegaert commentedsubscribe
Comment #108
willhowlett CreditAttribution: willhowlett commentedno need to type subscribe anymore josegaert: http://drupal.org/node/1306444
Comment #109
yannickoo#38 fixed the issue yeah!
Comment #110
3CWebDev CreditAttribution: 3CWebDev commentedReporting that #38 fixed it for me too!
Comment #111
blainelang CreditAttribution: blainelang commentedCan we possibly get the patch in #38 committed and close of this issue.
Comment #112
star-szrThe patch in #38 still needs work as per fago in #95 and #96.
Comment #113
vrMarc CreditAttribution: vrMarc commented#38: issue_1329856_1.patch queued for re-testing.
Comment #114
star-szrComment #115
kscheirerThis seems like a blocker for getting a 1.0 module release out, which is part of the D7 Upgrade Initiative. Can we get an updated issue summary and steps to reproduce the bug?
I think the current state is that the patch from #38 needs a better test than
$form_state['clicked_button']['#name'] == 'op'
. What are we testing for exactly?Comment #116
tim.plunkettThis is an edge case bug, not a critical one. But it can be a release blocker.
Comment #117
spessex CreditAttribution: spessex commentedPatch from #38 eliminated the error but now getting the following when going back in the 'field collections' interface :
Notice: Undefined index: invoice in _field_ui_bundle_admin_path() (line 325 of /Applications/MAMP/htdocs/Linode/MRFGR/modules/field_ui/field_ui.module).
Notice: Undefined index: invoice in field_collections_overview() (line 26 of /Applications/MAMP/htdocs/Linode/MRFGR/sites/all/modules/field_collection/field_collection.admin.inc).
Comment #118
truyenle CreditAttribution: truyenle commented#38 fixed for me also.
Comment #120
roderikFYI / echoing #69 just for documentation:
It looks like #1468686-34: file_field_widget_submit(), file.field.inc using the wrong parent key fixes this in core. (Quicksketch confirms a core gotcha in #31.) Not sure whether that fixes all the problems reported here, but it may be an indication that this patch is not needed.
(Status: waiting to be included in D8 before being included in D7. #1468686-34 is the D7 fix.)
So the patch in #38 above issue can serve as a 'stop gap' until #1468686 is applied to core, if you like patching field_collection instead of drupal core... but it does not look like this needs more work.
Comment #121
almc CreditAttribution: almc commentedThank you, this core fix seems to have fixed the issue discussed in this thread - the mentioned warning messages don't appear after it's applied.
Comment #123
jmuzz CreditAttribution: jmuzz commentedNobody has mentioned this problem or needing #38 since the patch was applied to core, and the only person who reports still seeing the problem with the core patch wasn't using the patch version that eventually got committed so I'm marking this as fixed. Feel free to reopen if it still happens with the latest dev versions.