Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
video and audio types are inverted what breaks the player.
Moreover $raw_files
often already contains the type key.
Comment | File | Size | Author |
---|---|---|---|
#4 | jplayer-type-detection-1405680-4.patch | 1.1 KB | stevetweeddale |
#1 | 1405680-1-revert-audio-video.patch | 802 bytes | drzraf |
Comments
Comment #1
drzraf CreditAttribution: drzraf commentedComment #2
deviantintegral CreditAttribution: deviantintegral commentedFunctionally this looks fine, but there are some code style / spacing issues to be cleaned up.
Comment #3
drzraf CreditAttribution: drzraf commentedit is not an issue, I encapsulated a block in a
if
statement thus I generated the commit withdiff -w
in order to make the change readable.1 files changed, 13 insertions(+), 11 deletions(-)
1 files changed, 4 insertions(+), 2 deletions(-)
Comment #4
stevetweeddale CreditAttribution: stevetweeddale commentedAttached a cleaned up version of #1.
Comment #5
stevetweeddale CreditAttribution: stevetweeddale commentedHold the phone, looks like this has already been fixed in #1192826: Undefined variable: player_type in jplayer_sort_files() in the within the patch in #19. Gah.
Comment #6
deviantintegral CreditAttribution: deviantintegral commentedSince that patch is still at needs review, I committed this in dafadd3.