I was struck today by the fact that cache_get() and cache_set() don't @see each other. It seems like a natural reference, as I kept finding myself wanting to jump between them while looking on a.d.o. Note that this does not apply to D8 as both of these functions are gone, replaced by the new pluggable cache objects.

Patch to follow.

CommentFileSizeAuthor
#8 cache_docs-1421330-d6-8.patch782 bytesAlbert Volkman
#5 cache_docs-1421330-d6-5.patch782 bytesAlbert Volkman
#1 1421330_cache_docs.patch786 bytesgdd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
CreditAttribution: gdd commented
Status: Active » Needs review
FileSize
1421330_cache_docs.patch786 bytes
Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Needs review » Reviewed & tested by the community

Useful and logical, seeing as both variable_get and variable_set have '@see's to each other.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)

How about a D6 backport?

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Patch (to be ported) » Needs review
FileSize
cache_docs-1421330-d6-5.patch782 bytes

D6 backport.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented

Oops, double post. Ignore.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
CreditAttribution: gdd commented
Status: Needs review » Needs work

You have @see cache_set on cache_set() :)

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
cache_docs-1421330-d6-8.patch782 bytes

How to keep a developer busy :) Thanks for the catch!

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks good this time. :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed, pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.