httprl_lock_release() not upgraded to D7 [#1420092]

Recoverable fatal error: Argument 2 passed to db_query() must be an array, string given, called in \drupal7\sites\all\modules\httprl\httprl.nonblocktest.inc on line 43 and defined in db_query() (line 2309 of \drupal7\includes\database\database.inc).

Comment	File	Size	Author
#8	1420092_WSOD_because_of_suppressed_D6_leftover_error.patch	803 bytes	hass
#4	httprl-1420092-4-fix-d7-db_query-syntax-issue.patch	529 bytes	mikeytown2
#2	1420092 httprl_lock_release() not upgraded to D7.patch	589 bytes	hass
#1	1420092 httprl_lock_release() not upgraded to D7.patch	577 bytes	hass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hass CreditAttribution: hass commented 29 January 2012 at 17:31

Title:	Argument 2 passed to db_query() must be an array, string given	» httprl_lock_release() not upgraded to D7
Status:	Active	» Needs review

File	Size
1420092 httprl_lock_release() not upgraded to D7.patch	577 bytes

Comment #2

hass CreditAttribution: hass commented 29 January 2012 at 17:49

File	Size
1420092 httprl_lock_release() not upgraded to D7.patch	589 bytes

Let's use this one, it's better readable.

Comment #3

hass CreditAttribution: hass commented 29 January 2012 at 19:12

I don't know why, but fixing this bug *may* cause a WSOD on report status page and config page after all caches have been cleared. Strange... i cannot find the source of the WSOD.

Comment #4

mikeytown2 CreditAttribution: mikeytown2 commented 1 February 2012 at 04:32

Status:

Needs review

» Fixed

File	Size
httprl-1420092-4-fix-d7-db_query-syntax-issue.patch	529 bytes

This patch has been applied to 6.x & 7.x

Comment #5

hass CreditAttribution: hass commented 2 February 2012 at 01:32

Status:

Fixed

» Needs work

As noted above, I see only a WSOD on admin/reports/status. Nothing logged in watchdog and apache error logs, but I get a white page... :-(

Comment #6

mikeytown2 CreditAttribution: mikeytown2 commented 2 February 2012 at 02:17

Status:

Needs work

» Postponed (maintainer needs more info)

I can't repo your report on my D7 site. Try running with this at the bottom of your settings.php file.

  // Report all php errors.
  error_reporting(-1);
  // Show Errors in output
  ini_set('display_errors', '1');
  // Display all errors using drupal_set_message().
  $conf['error_level'] = 2;

Comment #7

hass CreditAttribution: hass commented 4 February 2012 at 01:32

Priority:

Normal

» Critical

For release. My site is broken...

Comment #8

hass CreditAttribution: hass commented 4 February 2012 at 02:23

Status:

Postponed (maintainer needs more info)

» Needs review

File	Size
1420092_WSOD_because_of_suppressed_D6_leftover_error.patch	803 bytes

Heck... by suppressing errors with @ you made it really hard to track down...

Fatal error: Call to undefined function db_result() in \drupal7\sites\all\modules\httprl\httprl.install on line 124

It would be a good idea to enable automated testing on the project... :-)

Comment #9

hass CreditAttribution: hass commented 4 February 2012 at 03:35

Version:

7.x-1.x-dev

» 7.x-1.4

Comment #10

hass CreditAttribution: hass commented 4 February 2012 at 15:10

$result = db_query('SELECT value FROM {variable} WHERE name = :name', array(':name' => 'httprl_server_addr'))->fetchAssoc(); may be a candidate to get changed to ->fetchField()