This would allow the characteristics of this link to be changed by modules, themes, etc. based on more specific requirements.

This will also help:
#347698: change 'Join' link to 'Login to join'
#215276: Adding link to OG Block Menu when Group is in Moderation
maybe #1372346: Customized member invitation based on user type

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

goron’s picture

Status: Active » Needs review
FileSize
3.16 KB

Here's a patch

Grayside’s picture

Status: Needs review » Needs work

First line of function documentation should always be a one-liner description of what the function does, followed by an empty line, followed by additional text as needed, then parameters. @deprecated should be placed below the @param/@return items.

goron’s picture

Moved @deprecated.

goron’s picture

Status: Needs work » Needs review
Grayside’s picture

Status: Needs review » Needs work

Don't know how I missed it.

og_subscribe_link() should simply be a wrapper around theme('og_subscribe_link').

goron’s picture

Status: Needs work » Needs review
FileSize
2.83 KB

Ha. Oops.

Updated patch.

Grayside’s picture

Status: Needs review » Reviewed & tested by the community

Want to give this a little time to attract a second opinion.

hefox’s picture

Probably

This function is deprecated in favor of theme_og_subscribe_link() => This function is deprecated in favor of theme('og_subscribe_link'

As don't want people calling theme_og_subscribe_link directly.

Grayside’s picture

Status: Reviewed & tested by the community » Needs work

Good point.

Grayside’s picture

Status: Needs work » Fixed

http://drupalcode.org/project/og.git/commit/739ed8a

Committed with slight change.

The @deprecated tag marks that the original og_subscribe_link() function is not advised, and will be dropped after a couple releases.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.